Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp563840img; Thu, 28 Feb 2019 04:22:17 -0800 (PST) X-Google-Smtp-Source: AHgI3IZBca5qS9dsm5m8HGn3K1lx5EUziusMcPEx0ykhKYvoTsCPon4YMdcytPOonWTa45CT3i1D X-Received: by 2002:a17:902:f01:: with SMTP id 1mr7564992ply.41.1551356537302; Thu, 28 Feb 2019 04:22:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551356537; cv=none; d=google.com; s=arc-20160816; b=LDagrP6e1C2RwxBQqHRjIlxp63GlLWprAemLh0a6abGbaThGp5zwhQ7yMUlHRg1/Pq 7sA7BKyG6qGZYsNUXYVhgEW1b/exe3hpFDoQ34zHnrOsUHoB749MNpTG99P9wa1cS0Pi A684/gnDNxvM2OEz5jriWtr906TVQcF/MBXqlhjUDsVPXZUd8g6o3h9QYiAEaj0lune2 XFFawmRKlKDt2gFBPteiWhoXEIsMHvard+ROltE2A6mbuXofTPVjAMtw2mTgaHcDEJMN n/tXG0DUAzFH50Cp8BssAqDtJFG6bhVyOE3+OWtxnrdrkY2r8hSxaKjf5UFdn6T70OY+ LTLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=L8fcmR+rQmEReDcuYpUYxW0tKYPUtWoev1VscFLxHis=; b=jm4JnejNpIbqzAuGsO0v3M4aAp1lPc/Hr6JDkkKFWZVp++UJNySvvWymzkxh4gPtS7 hiDjn9QxDocQ8HAlnkRwKGcj1IOTp5/wCYPMgb9cELyRdTXUNxx+yFiwQWgl3MrLzjAX A5sXolGUzn7Jahg1GV96IUqj2GX0ue/BnzSvaop1XnhMyBGJ1crtdyRkWiVnvSHKlDr2 r4B8NhmOnhMZALOsOOvvRROrOUQw29/Hets4puTvJhP2iq3i0JuM0LUkJxJX7p4gG4Xm ic69lTxfIdIw50dVr+xewiHtTuoMl2POst8eGmHC4EoURP5mH3hWJXjgSfgHGx1BWey1 eQow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dMhcgLXP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v2si15545989pfe.117.2019.02.28.04.22.01; Thu, 28 Feb 2019 04:22:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dMhcgLXP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732282AbfB1L5B (ORCPT + 99 others); Thu, 28 Feb 2019 06:57:01 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:33936 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730976AbfB1L5B (ORCPT ); Thu, 28 Feb 2019 06:57:01 -0500 Received: by mail-lf1-f66.google.com with SMTP id u21so15055787lfu.1; Thu, 28 Feb 2019 03:56:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L8fcmR+rQmEReDcuYpUYxW0tKYPUtWoev1VscFLxHis=; b=dMhcgLXPtaIJ8dCC63OVyx+y559roriUbGChDiEyK76D9mm2mvpV+Mr47Uzk5F5zBs V79QA6AXgTBm3/Ww/X0wjRbY6VmTWxxftRvCDpAk7zBPU2BXSGgkwd1hYK04SUoFKST6 M/Qt5bDlNhN07ksiqepq8iSHE2zJGTK+IagegRaVbteW3txRORTNC9u1GFiBBE/iM0Hb QcCzKZKLj1dHRkjUh4tRAu5Qmu/tmLb6SGUAKqrxPOX5rOltee5eSX0J5u/tHAGLby/z VGgC7v+aZIqB4j0LdHlVwBw0IRklfOgpgW5TxMI9bdSRjYfdjwUaIAS89bu9kHfh+rDh PRRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L8fcmR+rQmEReDcuYpUYxW0tKYPUtWoev1VscFLxHis=; b=fqVFGUPC4K1/kefFDKuu5XdikIhU+PJJ5qPwZHscOxyUD973SeH0gsJ+h2c6nboVvz Fxfds6lvKdLBvIoB1LSGATH+RNFDO+hwbCc5sAJXCxGMC3zja/L0y2LYbqY9wszWVZEX /LkZbGKX6UQwhefOF8mCXIC+5rxRjecfBafaKV6B1Fk2dBK59OP9JEGmwmhX1XEOfLKs 7fdpSF1WOtBL1dNl/vM5Buvf5phTTsjECAeIaAyx1iimCs8gsiK/R1MYRUaCaSWiX8Df P5iugIA+5uGG/VkUGuSKYgcjiO7OuUE0dpyC+Z00Kns1sYXx15KCG4MCfbjbQYhJBP/C 3KiQ== X-Gm-Message-State: AHQUAuZNhDwnBgknZrp5qocuZYnGBMbGu7N8wlskAFrptx08XMIjqLGT /NcOj6qtYpvh365nTPq1nFJAHSr2kUMGlRM3Vw/PFw== X-Received: by 2002:a19:ab19:: with SMTP id u25mr3993927lfe.64.1551355018788; Thu, 28 Feb 2019 03:56:58 -0800 (PST) MIME-Version: 1.0 References: <20190227205242.77355-1-cai@lca.pw> In-Reply-To: <20190227205242.77355-1-cai@lca.pw> From: Souptick Joarder Date: Thu, 28 Feb 2019 17:26:47 +0530 Message-ID: Subject: Re: [PATCH] memcg: fix a bad line To: Qian Cai Cc: hannes@cmpxchg.org, Michal Hocko , vdavydov.dev@gmail.com, cgroups@vger.kernel.org, Linux-MM , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 28, 2019 at 2:22 AM Qian Cai wrote: > > Miss a star. > > Signed-off-by: Qian Cai I think, the change log is too short and could be little more. Otherwise, Acked-by: Souptick Joarder > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index af7f18b32389..d4b96dc4bd8a 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5747,7 +5747,7 @@ struct cgroup_subsys memory_cgrp_subsys = { > * > * | memory.current, if memory.current < memory.low > * low_usage = | > - | 0, otherwise. > + * | 0, otherwise. > * > * > * Such definition of the effective memory.low provides the expected > -- > 2.17.2 (Apple Git-113) >