Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp579672img; Thu, 28 Feb 2019 04:38:34 -0800 (PST) X-Google-Smtp-Source: AHgI3IadjYA6E6ldfQXCFnL0GKII+8K7i3zdszuvFrEQxB87DEQKaImhAWn9bAXS8AdZLuCQmZvw X-Received: by 2002:a62:1f5d:: with SMTP id f90mr151973pff.104.1551357514856; Thu, 28 Feb 2019 04:38:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551357514; cv=none; d=google.com; s=arc-20160816; b=ykaFEv8f1VRCZZWE4lNP8KcGNuomPGJqFSKsK/qStNaZsVWo/p2lj2LhHM6/RsWrBp aXKBIGHUHnR02ykaKGDrHIKxinsiXk/AJUvm7jQNlWbb0Jp8bOC8LLYRSW9TJNKpIZVI /Z2n6Or3xFAf4gbPjCIE8gCMC9GmcY4+IdbU5jAeRSUqihJsjejQiVthsqSg2VAF1UsM uu/N4LVA7T/y0sO4WagVsSwJN4h4eLyNK2CFiL+HM0btnaoSC5Oo5zEo3MipyuyCyvzH FSD2NksO7bxMCr601bZUTbwB/vn+ELBOocmSfpf06ji6/VFB3y8K2L7b0otRo1B2Y5Pb ruFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=aOWcviKSM7EyFDiMyUztYClawRyKpwOriSXSy0Z5Csw=; b=ZyCgSgkzPbszafsc66sD9ByI9nVyE2PmWcfhTbyzqQDkZugS+4zJh+191dwOmMDfBF DSQUc3uk75DTOcj5/PDRMo3kEivw5lKQofE/nFhP6RZRZNlKb3G0S7UZOy8pb5BhKTfv 7du2ej1zPEN/6NKel/NjyXbstFtx3BMIjAEBjX1Ey+7Vg4efTIrk7z+OsU9mlLb7QF0E QQFM0ZGtt2wX7A9JC1hQwCDuq2wgXDevqJjSnFC2QeyFmYWkadHI4jHkrZ1DHgbWj820 cH6hmhWxlHN2vZv14OtqzyM49/PST2QnkhlT+RSiIwQJwlhms5OwuBrw72pcS4OSnnfT yJig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u18si8915294pgk.440.2019.02.28.04.38.18; Thu, 28 Feb 2019 04:38:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731558AbfB1Mh5 (ORCPT + 99 others); Thu, 28 Feb 2019 07:37:57 -0500 Received: from smtp03.citrix.com ([162.221.156.55]:25002 "EHLO SMTP03.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730994AbfB1Mh5 (ORCPT ); Thu, 28 Feb 2019 07:37:57 -0500 X-IronPort-AV: E=Sophos;i="5.58,423,1544486400"; d="scan'208";a="79318758" Date: Thu, 28 Feb 2019 12:37:48 +0000 From: Wei Liu To: Paul Durrant CC: Wei Liu , Igor Druzhinin , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "davem@davemloft.net" Subject: Re: [PATCH] xen-netback: fix occasional leak of grant ref mappings under memory pressure Message-ID: <20190228123748.5nabuvg44sjiecdz@zion.uk.xensource.com> References: <1551319382-32595-1-git-send-email-igor.druzhinin@citrix.com> <8424fba34a1f43908a6dae3a9308863b@AMSPEX02CL02.citrite.net> <20190228110136.somjads2f5ivqhju@zion.uk.xensource.com> <0aa1850892c94d6ba7543bf322734614@AMSPEX02CL02.citrite.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0aa1850892c94d6ba7543bf322734614@AMSPEX02CL02.citrite.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 28, 2019 at 12:07:07PM +0000, Paul Durrant wrote: > Yes, I meant kfree_skb(nskb). > In that case I think your patch looks fine. Wei.