Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190221221941.29358-1-daniel@iogearbox.net> <tip-ce02ef06fcf7a399a6276adb83f37373d10cbbe1@git.kernel.org>
 <33bf951448e7d916fd4a6ad41cd3d040e9d1f118.camel@infradead.org>
In-Reply-To: <33bf951448e7d916fd4a6ad41cd3d040e9d1f118.camel@infradead.org>
From:   "H.J. Lu" <hjl.tools@gmail.com>
Date:   Thu, 28 Feb 2019 04:53:34 -0800
Message-ID: <CAMe9rOrcOVRWuNWy3xp7NMD=2UbGH+C5zifDhd=-AxrrzEVrmw@mail.gmail.com>
Subject: Re: [tip:x86/build] x86, retpolines: Raise limit for generating
 indirect calls from switch-case
To:     David Woodhouse <dwmw2@infradead.org>
Cc:     daniel@iogearbox.net, Ingo Molnar <mingo@kernel.org>,
        bjorn.topel@intel.com, David Miller <davem@davemloft.net>,
        brouer@redhat.com, magnus.karlsson@intel.com,
        Andy Lutomirski <luto@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>, ast@kernel.org,
        linux-tip-commits@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 28, 2019 at 3:27 AM David Woodhouse <dwmw2@infradead.org> wrote=
:
>
> On Thu, 2019-02-28 at 03:12 -0800, tip-bot for Daniel Borkmann wrote:
> > Commit-ID:  ce02ef06fcf7a399a6276adb83f37373d10cbbe1
> > Gitweb:     https://git.kernel.org/tip/ce02ef06fcf7a399a6276adb83f37373=
d10cbbe1
> > Author:     Daniel Borkmann <daniel@iogearbox.net>
> > AuthorDate: Thu, 21 Feb 2019 23:19:41 +0100
> > Committer:  Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Thu, 28 Feb 2019 12:10:31 +0100
> >
> > x86, retpolines: Raise limit for generating indirect calls from switch-=
case
> >
> > From networking side, there are numerous attempts to get rid of indirec=
t
> > calls in fast-path wherever feasible in order to avoid the cost of
> > retpolines, for example, just to name a few:
> >
> >   * 283c16a2dfd3 ("indirect call wrappers: helpers to speed-up indirect=
 calls of builtin")
> >   * aaa5d90b395a ("net: use indirect call wrappers at GRO network layer=
")
> >   * 028e0a476684 ("net: use indirect call wrappers at GRO transport lay=
er")
> >   * 356da6d0cde3 ("dma-mapping: bypass indirect calls for dma-direct")
> >   * 09772d92cd5a ("bpf: avoid retpoline for lookup/update/delete calls =
on maps")
> >   * 10870dd89e95 ("netfilter: nf_tables: add direct calls for all built=
in expressions")
> >   [...]
> >
> > Recent work on XDP from Bj=C3=B6rn and Magnus additionally found that m=
anually
> > transforming the XDP return code switch statement with more than 5 case=
s
> > into if-else combination would result in a considerable speedup in XDP
> > layer due to avoidance of indirect calls in CONFIG_RETPOLINE enabled
> > builds.
>
> +HJL
>
> This is a GCC bug, surely? It should know how expensive each
> instruction is, and choose which to use accordingly. That should be
> true even when the indirect branch "instruction" is a retpoline, and
> thus enormously expensive.
>
> I believe this is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D86952 so
> please at least reference that bug, and be prepared to turn this hack
> off when GCC is fixed.

We couldn't find a testcase to show jump table with indirect branch
is slower than direct branches.

--=20
H.J.