Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp728796img; Thu, 28 Feb 2019 07:01:06 -0800 (PST) X-Google-Smtp-Source: AHgI3IYIJLYFLklMlhH2ryXFd9ZsYe5tj+xziK9ij/zLIJP2K37GoYLdwQO/w0bez2Pbn3+6dK4+ X-Received: by 2002:a63:360e:: with SMTP id d14mr8925276pga.179.1551366065959; Thu, 28 Feb 2019 07:01:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551366065; cv=none; d=google.com; s=arc-20160816; b=BcngF/pYtT/ueG/llNHtoY2xV+BXuo2FIeq3QVod+q7O9mrdTfrrdg3QlU59wYpsKT 6a17E/mr2mj91Yv30OciizndrOFuf9GkTxcI+hdvWhitUuhPRoHrLzvwMUZEq70hCiAY EQxdk5yqIWKMA1+nfg/FjzZu6KxIoVkJdvTRXlpOlNoDTJB86nwhsxGQzKU3AyYr7Unw V2sw4RgP+f4ObBXXn1+LHKTRRR1QGU1Ml/Uw/SO8gxT5HrrpLoY/eMnnBZMpjjSFl+b4 SpbmxwWlFSsZtRnceFhlcGdiJJCO0z29zICqVLIpsm+G/O9iXNx9zNLoVKtzdvHQFaY/ HnOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=G4X2ZiLU7B33DnhaTnVeog/cj9ygwjHiAP8mCmj9Eqo=; b=QIHXJ9lVdsFRj5hz6ksdxqo4pedFYNxaHzy77JE77lFMBCxRQEXb+WtJLI3i8KX+eS NiDioZUZhXdF53CWZ9u38oQPdAeoshuW0pd3wbIk0fKaMQloyGARG2K4anGbYLYXkmLm /f6Uh5tULjlLCulfP5F6zYMhCGf6PqT8EL2BoIYbVyGg0znu7mC+vxyiLwX9VChqJcgz W6AMrKu1JKrAkWxlZ+Iw8CcoaQUW/LfXo6Rlru3eqi9epeZ4cBG4JunhIPNOM8UEnv5e FMAd9OFWLl5j2UOe3pjunBkMFFCi+RfkgxVCYM//JdWFEbrHiKWBWjaZhf9oHvIUNKhK pPUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=i+neshkA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r7si17643630pgi.20.2019.02.28.07.00.49; Thu, 28 Feb 2019 07:01:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=i+neshkA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732844AbfB1OZP (ORCPT + 99 others); Thu, 28 Feb 2019 09:25:15 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:44214 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727826AbfB1OZP (ORCPT ); Thu, 28 Feb 2019 09:25:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G4X2ZiLU7B33DnhaTnVeog/cj9ygwjHiAP8mCmj9Eqo=; b=i+neshkAh4jIOoiciWGaq1FZsp tzpvNaGUkQfb4JemQmRPqftp+jIN68LquJuME3penAkgjd6cNaNa4IYBWcK3adD217r2e8E/lTi76 rL+sf4yQC3dkEGqypNPHD0g1cjXqEs6aohjgsTf6u6R+Se6tT380Gbg+0yw480yKLFxKXUpT+x+xs GaV6k3uHC4+r6wnrJ4CmjvvI0Mcjp5VFg8yXAGfkF/jSdSPZa7wRbZcApw61FIKSdBu9IXqfJvJyi t0yZozRqfzDLv58zYSfYu3PIaMUFM/2ejGPNXxj7DRyz/FtSJ6zVSh4VSZngwelN6Zwjw6wrP4Gz6 pqQXqC2g==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzMcc-0001Rk-MY; Thu, 28 Feb 2019 14:25:14 +0000 Date: Thu, 28 Feb 2019 06:25:14 -0800 From: Christoph Hellwig To: Robert Eshleman Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/8] net: ethernet: reduce calls to memset(,0) Message-ID: <20190228142514.GB18319@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 26, 2019 at 10:04:54PM -0800, Robert Eshleman wrote: > This patch series removes calls to memset(,0) that are > redundant when used in conjunction with a zalloc call or > by simple zero-assignment of structs. NAK. pci_zalloc_consistent is just as deprecated as pci_alloc_consistent, and if you look at the implementation you'll see that we actual zero the memory for both of them. If you want to do some DMA-related busy work please just bulk convert drivers from the PCI DMA API to the proper generic DMA API. Bonus points for automatіng that using a cocchinelle script.