Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Feb 2019 16:06:00 +0100
From:   Antoine Tenart <antoine.tenart@bootlin.com>
To:     Yan Markman <ymarkman@marvell.com>
Cc:     Antoine Tenart <antoine.tenart@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "maxime.chevallier@bootlin.com" <maxime.chevallier@bootlin.com>,
        "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        Nadav Haklai <nadavh@marvell.com>,
        Stefan Chulski <stefanc@marvell.com>,
        "mw@semihalf.com" <mw@semihalf.com>
Subject: Re: [EXT] [PATCH net-next 15/15] net: mvpp2: set the GMAC, XLG MAC,
 XPCS and MPCS in reset when a port is down
Message-ID: <20190228150600.GG4359@kwain>
References: <20190228132128.30154-1-antoine.tenart@bootlin.com>
 <20190228132128.30154-16-antoine.tenart@bootlin.com>
 <DM5PR18MB2134A10888F49613CC9ECCB7D6750@DM5PR18MB2134.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <DM5PR18MB2134A10888F49613CC9ECCB7D6750@DM5PR18MB2134.namprd18.prod.outlook.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Yan,

On Thu, Feb 28, 2019 at 03:00:34PM +0000, Yan Markman wrote:
> 
> The eth-down/stop may concurrent with pre-scheduled stats_work.
> So it seems better to cancel stats_work first and then make resetS.

I'm not sure this would actually result in an issue, but to keep it
logical I'll change that.

Thanks,
Antoine

> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 29d32cb3d52b..c10fd894c86f 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -3257,6 +3257,7 @@ static void mvpp2_stop_dev(struct mvpp2_port *port)
>  
>  	if (port->phylink)
>  		phylink_stop(port->phylink);
> +
>  	phy_power_off(port->comphy);
>  }
>  
> @@ -3520,6 +3521,9 @@ static int mvpp2_stop(struct net_device *dev)
>  	mvpp2_cleanup_rxqs(port);
>  	mvpp2_cleanup_txqs(port);
>  
> +	mvpp2_mac_reset(port);
> +	mvpp22_pcs_reset(port);
> +
>  	cancel_delayed_work_sync(&port->stats_work);
>  
>  	return 0;

-- 
Antoine T?nart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com