Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261369AbUCQKgN (ORCPT ); Wed, 17 Mar 2004 05:36:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261393AbUCQKgI (ORCPT ); Wed, 17 Mar 2004 05:36:08 -0500 Received: from mtagate1.de.ibm.com ([195.212.29.150]:58836 "EHLO mtagate1.de.ibm.com") by vger.kernel.org with ESMTP id S261369AbUCQKgB (ORCPT ); Wed, 17 Mar 2004 05:36:01 -0500 In-Reply-To: <1079473944.1804.21.camel@mulgrave> To: James Bottomley Cc: Andrew Morton , Linux Kernel , SCSI Mailing List , linux-scsi-owner@vger.kernel.org, Martin Schwidefsky MIME-Version: 1.0 Subject: Re: [PATCH] s390 (8/10): zfcp fixes. X-Mailer: Lotus Notes Release 6.0.2CF1 June 9, 2003 Message-ID: From: Heiko Carstens Date: Wed, 17 Mar 2004 11:35:23 +0100 X-MIMETrack: Serialize by Router on D12ML064/12/M/IBM(Release 6.0.2CF2|July 23, 2003) at 17/03/2004 11:35:15, Serialize complete at 17/03/2004 11:35:15 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1035 Lines: 22 > > +ZFCP_DEFINE_SCSI_ATTR(hba_id, "%s\n", zfcp_get_busid_by_unit(unit)); > > +ZFCP_DEFINE_SCSI_ATTR(wwpn, "0x%016llx\n", unit->port->wwpn); > > +ZFCP_DEFINE_SCSI_ATTR(fcp_lun, "0x%016llx\n", unit->fcp_lun); > These attributes all properly belong in the fibrechannel transport > class, could you look at moving them over, please. We can certainly do that for the wwpn (->port_name). For the fcp_lun we would need to extend the fc transport class. The hba_id doesn't belong to the fc transport class at all. It's just the busid of our host adapter, so that we can identify it uniquely. By the way, Christoph asked why we have the zfcp lldd in drivers/s390/scsi. This is just for historical reasons. If you don't mind seeing a ~32000 lines patch we can move it to drivers/scsi/zfcp. Heiko - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/