Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261366AbUCQLPp (ORCPT ); Wed, 17 Mar 2004 06:15:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261375AbUCQLPp (ORCPT ); Wed, 17 Mar 2004 06:15:45 -0500 Received: from witte.sonytel.be ([80.88.33.193]:59821 "EHLO witte.sonytel.be") by vger.kernel.org with ESMTP id S261366AbUCQLPo (ORCPT ); Wed, 17 Mar 2004 06:15:44 -0500 Date: Wed, 17 Mar 2004 12:15:37 +0100 (MET) From: Geert Uytterhoeven To: Ian Campbell cc: Linux Kernel Mailing List , Linux Frame Buffer Device Development , James Simmons Subject: Re: [PATCH] PXA255 LCD Driver In-Reply-To: <1079521633.13370.39.camel@icampbell-debian> Message-ID: References: <1079518182.13373.27.camel@icampbell-debian> <1079521633.13370.39.camel@icampbell-debian> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 29 Hi Ian, On Wed, 17 Mar 2004, Ian Campbell wrote: > > > +For example: > > > + modprobe pxafb options=xres:640,yres:480,bpp:8,passive > > > > Not much comments, except: why don't you use the standard modedb mode parameter > > style? > > I was trying too (I mostly copied the i810 driver). How wrong did I get > it? I'm willing to rework it to make it the same as the standard. Take a look at drivers/video/modedb.c and fb_find_mode(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/