Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Tejun Heo <tj@kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH 0/6] mm: memcontrol: clean up the LRU counts tracking
Thread-Topic: [PATCH 0/6] mm: memcontrol: clean up the LRU counts tracking
Thread-Index: AQHUz4L9n1k+P/DTd06CcNJjAIxXeaX1ajQA
Date:   Thu, 28 Feb 2019 16:42:41 +0000
Message-ID: <20190228164236.GA26032@tower.DHCP.thefacebook.com>
References: <20190228163020.24100-1-hannes@cmpxchg.org>
In-Reply-To: <20190228163020.24100-1-hannes@cmpxchg.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::1:d847]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ca868cf1-04d0-4662-6835-08d69d9bc189
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:BYAPR15MB2613;
x-ms-traffictypediagnostic: BYAPR15MB2613:
x-microsoft-exchange-diagnostics: 1;BYAPR15MB2613;20:CdH1bil/aSwZNUcLnnmHBIMrTZMVhFjvsRJOenhOSIThgn6Qi340uxG5duQk0dVXjq7DairCWLiQnmE06ho6DuprQgHSR6Mg9DYocYuT8kwpRbbCyFbhOFSlHu+tG2r/8aycZX1TMsxzuJNHDU4gv07uVlW+tgskuy2Xno4KUpE=
x-microsoft-antispam-prvs: <BYAPR15MB26137AC1C9C32EEB2C0E92B1BE750@BYAPR15MB2613.namprd15.prod.outlook.com>
x-forefront-prvs: 0962D394D2
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(396003)(376002)(346002)(366004)(136003)(199004)(189003)(54906003)(81166006)(81156014)(6246003)(25786009)(71200400001)(71190400001)(8676002)(68736007)(8936002)(4326008)(7736002)(6916009)(305945005)(478600001)(97736004)(316002)(2906002)(6512007)(9686003)(256004)(86362001)(14454004)(46003)(1076003)(33656002)(229853002)(6486002)(52116002)(106356001)(53936002)(446003)(105586002)(11346002)(6436002)(76176011)(102836004)(6116002)(5660300002)(6506007)(486006)(99286004)(186003)(476003)(386003);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB2613;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: JEeQyWXCJK2lSNNhTR5JCD9AwZv/MglfP9Hxw1zi5G7NNrSaLsEXsTUAAGF1kfDRspiPJdeGsJasnUXNFZCHVufNsM1/CPoyHMoUY3yEN2m6jIZT4e++apvZXsnJEfloEmuGkUsJOpRhSr66ewbXeqLES5kL6Qj5AeHNbLMDlvhd5FKMhvm2vY6ylZvcP2dCslq4xEaXBxhgz5kSSm2UhIogMwJj+503l++ByYbo45e5ovOQ+y4KeCgugRHBsF7hhxfeOV6o/cN+EdxuwXX5G/UD5keGnWvIed5OIVexlBm/bUO0Tn8OnR/I1Lum8nlq1Dju6ST8KiFeir8E2E5sIE8+ulj4Y4ro9iRMM4CoPPvuF8fzCIEP8g2VQTodNh9Tqv89GmRMn4ceNVesfnX6C8/il+Iwv2F7Do2yZyBLit0=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <FF49BB458586CF448F1935237336EB36@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ca868cf1-04d0-4662-6835-08d69d9bc189
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 16:42:41.4955
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2613
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-28_08:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 28, 2019 at 11:30:14AM -0500, Johannes Weiner wrote:
> [ Resend #2: Sorry about the spam, I mixed up the header fields in
>   git-send-email and I don't know who did and didn't receive the
>   garbled previous attempt.
>=20
>   Resend #1: Rebased on top of the latest mmots. ]
>=20
> The memcg LRU stats usage is currently a bit messy. Memcg has private
> per-zone counters because reclaim needs zone granularity sometimes,
> but we also have plenty of users that need to awkwardly sum them up to
> node or memcg granularity. Meanwhile the canonical per-memcg vmstats
> do not track the LRU counts (NR_INACTIVE_ANON etc.) as you'd expect.
>=20
> This series enables LRU count tracking in the per-memcg vmstats array
> such that lruvec_page_state() and memcg_page_state() work on the enum
> node_stat_item items for the LRU counters. Then it converts all the
> callers that don't specifically need per-zone numbers over to that.
>=20
>  include/linux/memcontrol.h | 28 ---------------
>  include/linux/mm_inline.h  |  2 +-
>  include/linux/mmzone.h     |  5 ---
>  mm/memcontrol.c            | 85 +++++++++++++++++++++++++---------------=
----
>  mm/vmscan.c                |  2 +-
>  mm/workingset.c            |  5 +--
>  6 files changed, 54 insertions(+), 73 deletions(-)
>=20
>=20


The patchset looks very good to me!

Reviewed-by: Roman Gushchin <guro@fb.com>

Thanks!