Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp972238img; Thu, 28 Feb 2019 10:47:48 -0800 (PST) X-Google-Smtp-Source: AHgI3IYNOpN85hJyJEWpz4jeLt5AMXR5pKGaaWR7txqR4eQEDn3/LOKlrBGnqcwK0QUyMe4JJrS+ X-Received: by 2002:aa7:8299:: with SMTP id s25mr1076756pfm.56.1551379668867; Thu, 28 Feb 2019 10:47:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551379668; cv=none; d=google.com; s=arc-20160816; b=gRMffOpD9MxsgDYEpAbL7eh86+5lpqEYn2k3lKPFrPtvOvMqWeYp6AkgIsTx6KveAj cN4o6Dre+/hjt2q+yCBT4yg6P4A2XgRIZpik1g2V1iCNhV4UV6ifgT5PTWbRvZYz5EJt kV6XwSux2DoxzP3lxSVuu9Gmcng5z09r65DHYFQq/9CIErZQANkaZRPHRXtoyGVG5DEO 9OsNR36yl1uM5GAPjdaI59NVOArbFKcuxHTDakoq5dPt37O8T1uYeBrp3PsEb2nsi9F2 AhWWQShtZJE2py9kqLDqBN/gJlUYKgw77OVRrrpokIBCAXXOKnpoON1nEeb+6sAQVTBj /1BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=ZnplVlbm1Fztuiu2an74qTJaN8yoAPf/g6n2PmpRNZs=; b=m4WihyGCcTGfHn7RrxFW/ujpHAtsqQcxhWKxVStlFLk74YevSQ5rN4ExhQh+sT69Z/ 7NqhQagUaB+7bdX57vX+M1BJqqMCsrdMqR7tDNWKS5gDutFd9OgR8oo2CwsJDULUQfvT mT1Lq+8gHfY8NWuATQG40184/qDsSYLLFq8LhReOuHmByuo3DWVphRufWB8lPqAfYh1T IjBQ13p6W3K6FqElA8K2F4jnv1MYJnwllBKOM34E/yMVBTm/gHyBlHDvr+Zh4q67ctFW PRZwRztLiQEa+kMv6FfmrZRSEQAoiii9xUOr5FWGWRbytewjJIbe3YpcUkUN8vLjjnPL llmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si19497761ple.390.2019.02.28.10.47.33; Thu, 28 Feb 2019 10:47:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732748AbfB1SWc (ORCPT + 99 others); Thu, 28 Feb 2019 13:22:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35158 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726311AbfB1SWb (ORCPT ); Thu, 28 Feb 2019 13:22:31 -0500 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id A4D50ADFA; Thu, 28 Feb 2019 18:22:30 +0000 (UTC) Date: Thu, 28 Feb 2019 10:22:29 -0800 From: Andrew Morton To: William Kucharski Cc: Andrey Ryabinin , Johannes Weiner , Vlastimil Babka , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Mel Gorman Subject: Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly Message-Id: <20190228102229.dec5e125fc65a3ff7c6f865f@linux-foundation.org> In-Reply-To: <7AF5AEF9-FF0A-41C1-834A-4C33EBD0CA09@oracle.com> References: <20190228083329.31892-1-aryabinin@virtuozzo.com> <20190228083329.31892-2-aryabinin@virtuozzo.com> <7AF5AEF9-FF0A-41C1-834A-4C33EBD0CA09@oracle.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Feb 2019 05:53:37 -0700 William Kucharski wrote: > > On Feb 28, 2019, at 1:33 AM, Andrey Ryabinin wrote: > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index a9852ed7b97f..2d081a32c6a8 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -1614,8 +1614,8 @@ static __always_inline void update_lru_sizes(struct lruvec *lruvec, > > > > } > > > > -/* > > - * zone_lru_lock is heavily contended. Some of the functions that > > +/** > > Nit: Remove the extra asterisk here; the line should then revert to being unchanged from > the original. I don't think so. This kernedoc comment was missing its leading /**. The patch fixes that.