Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp978912img; Thu, 28 Feb 2019 10:55:33 -0800 (PST) X-Google-Smtp-Source: APXvYqwvaUvAOqcIRcm9Dl/S9XoKa4n0d3gPxfBC7yEIU4elx+rnHgm7SN668rvR1ojQQcu1dyjF X-Received: by 2002:a65:410a:: with SMTP id w10mr623303pgp.206.1551380133485; Thu, 28 Feb 2019 10:55:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551380133; cv=none; d=google.com; s=arc-20160816; b=hRoFIhGRN90wJflpPr5+bnF3sT2Jd87RhA3G1glhWqHRJc5srOua6eKMTUkMYw+gYI ZwN1iv4AkUAh3a/VxA5veKMTL1RS/6JQhjExyRGk2r4ehAf3AqcplOTcKPMna2aNMexy lY2IEmuXMN0vCEEUs966tenKaFKhUpDdC5/BeHuc4zmiS8HBR5Fn9zwaImQrGhpcr2mf YXXsP6sk19W91otE3grk+wWkJ45w5NGYI3f9q65GjBF5F6Rtb85WMvASmdiqkardavUl DmyzOk0le/+CPH1cjycimB6aDer1toiajDiQPq7QXmQdq/0oInqsBeoUOLxU5rj6O+C+ tOkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=XCNz6UsX8KgAjD9h+Q0d8K7y24duwHAfI56vza7QZRk=; b=I4QAtkZRpxovtTRbAfAVKe5zE3GVF6O950JMpLbzlIoEKE/yQN+RpR3YlpqccsYTmu pKAWfUDiwxlNv89IvJR260sS1AjZSLBML9U90w0OKZ5rjkh3K0d/1tfPuM/pnEMm4kK3 tqPhXEPHyJNVfmwBxKzaJgMDXf23Ixh/goK51MpM5j+npDhZQOhM0BxemSrPQhr0drf6 UQdIn9qFFtZ04pxYS2Sj4kL5hB8CdCVkoQ9JmSLcM5b0+POOgGspyBYVrhECnEqeBn3Z ztqtMgpn+7fmAYADdvzBdweXPgn3jIKt1+p0//h3n27SKXe7bW/khgjwkZ/nmmzyOSKR 8ffA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2si5935184pgp.444.2019.02.28.10.55.17; Thu, 28 Feb 2019 10:55:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388044AbfB1Skx (ORCPT + 99 others); Thu, 28 Feb 2019 13:40:53 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36668 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfB1Skw (ORCPT ); Thu, 28 Feb 2019 13:40:52 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D671614BA0BCD; Thu, 28 Feb 2019 10:40:51 -0800 (PST) Date: Thu, 28 Feb 2019 10:40:51 -0800 (PST) Message-Id: <20190228.104051.1946425715498350215.davem@davemloft.net> To: antoine.tenart@bootlin.com Cc: linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com Subject: Re: [PATCH net-next 14/15] net: mvpp2: set the XPCS and MPCS in reset when not used From: David Miller In-Reply-To: <20190228132128.30154-15-antoine.tenart@bootlin.com> References: <20190228132128.30154-1-antoine.tenart@bootlin.com> <20190228132128.30154-15-antoine.tenart@bootlin.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Feb 2019 10:40:52 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antoine Tenart Date: Thu, 28 Feb 2019 14:21:27 +0100 > +static void mvpp22_pcs_reset(struct mvpp2_port *port) > +{ > + struct mvpp2 *priv = port->priv; > + void __iomem *mpcs = priv->iface_base + MVPP22_MPCS_BASE(port->gop_id); > + void __iomem *xpcs = priv->iface_base + MVPP22_XPCS_BASE(port->gop_id); > + u32 val; Reverse christmas tree please. ... > +static void mvpp22_pcs_unreset(struct mvpp2_port *port) > +{ > + struct mvpp2 *priv = port->priv; > + void __iomem *mpcs = priv->iface_base + MVPP22_MPCS_BASE(port->gop_id); > + void __iomem *xpcs = priv->iface_base + MVPP22_XPCS_BASE(port->gop_id); > + u32 val; Likewise.