Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Feb 2019 11:19:08 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
Cc:     Ingo Molnar <mingo@redhat.com>, Al Viro <viro@ZenIV.linux.org.uk>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing: Fix event filters and triggers to handle
 negative numbers
Message-ID: <20190228111908.3c949478@vmware.local.home>
In-Reply-To: <f0929165-bc75-c13a-7a20-43262ef8a496@virtuozzo.com>
References: <20180823102534.7642-1-ptikhomirov@virtuozzo.com>
        <20180823204849.3b4aede3@vmware.local.home>
        <f0929165-bc75-c13a-7a20-43262ef8a496@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 28 Feb 2019 09:11:37 +0000
Pavel Tikhomirov <ptikhomirov@virtuozzo.com> wrote:

> ping, looks like the patch was lost
> 
> On 8/24/18 3:48 AM, Steven Rostedt wrote:
> > On Thu, 23 Aug 2018 13:25:34 +0300
> > Pavel Tikhomirov <ptikhomirov@virtuozzo.com> wrote:
> >   
> >> Then tracing syscall exit event it is extremely useful to filter exit
> >> codes equal to some negative value, to react only to required errors.
> >> But negative numbers does not work:
> >>
> >> [root@snorch sys_exit_read]# echo "ret == -1" > filter
> >> bash: echo: write error: Invalid argument
> >> [root@snorch sys_exit_read]# cat filter
> >> ret == -1
> >>          ^
> >> parse_error: Invalid value (did you forget quotes)?  
> > 
> > Thanks for the patch. I'll apply it and then start testing it!

?!?

I remember applying this to my git queue (I don't reply like this
before doing so). Not sure how it got lost. All I can think of is that
it might have been added with commits that ended up failing the tests,
and got reverted with that code :-/

I'm currently traveling. Hopefully I remember tomorrow to add this.
Thanks for pointing this out, and I need to be a bit more careful when
reverting failed commits :-p

-- Steve