Received: by 2002:ac0:8845:0:0:0:0:0 with SMTP id g63csp1121147img; Thu, 28 Feb 2019 13:26:19 -0800 (PST) X-Google-Smtp-Source: APXvYqxw1MWI/q35RtxqV7ROr6snVqCpxrMdHLmOdys68ZGS/rxUL7ycCDzJ52yXeoGnv8AJi2jE X-Received: by 2002:a17:902:b10f:: with SMTP id q15mr1605927plr.202.1551389179502; Thu, 28 Feb 2019 13:26:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551389179; cv=none; d=google.com; s=arc-20160816; b=rPKpYEaUzq0Yeaw5Kz2Etjg5JIpvODIhjrZwNFjyCVTERwGV6QpCQqUzpTHIHNWBoY 2yvGzWf7tzUiWdmXgX0WPHOVlCEKP7hWfVUh2JeIpTdbRCmV6Ba/3ZXOn0n0AfpGQjRB lk2znF7pN+1gyQ7N1WypqQHkp+DE88UXzrIkU0v5lledukARz6RKh1uslZnu5ezkEbk9 4HgdxiGyu2bbiHLaMsXd+mUo7sL31SkRTIheQfQDCqeiTf8haovF2npFk6TCQcNppaVA UgJUNweGzSRkGej4mLZGaYhsgmoO9IftZFyTvi+A641vwH5OOpueIhwxCxepKTWG/zeT T0MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization; bh=05dJZm35Ez/629qAyPzhgBxAX2qGzXgglT2GBitWm/8=; b=iKPQCjgq+0nNXJE26NBgNsU7hI++aEzyfHgNi5eni1vsxb5PDJwxo1yAhWQucPux01 IrVxFeiKJtI1pIfOBWjbv4vBqn4yy3u/nDIGfbaaQHAaYOVZ+rAJX4e/6YFfPp/RSjMy CRVTXraMqKa/aqUlJmf1STdvdQh5wnxTyZc20xvYFMXUlbUhXSriNK2UlIUPJmaMJhdh T+O+twmIBPOu1VBSvxOa9y1fDaq6gcuXXiYQHcQkohurn/hADamb02n3KWdl/nU5NBad LVtXg9pfUDoid+0kEzwhgkH1/GPntDz/ZyYjFEwBF+leDncetq6xVncWD16+MebRwanf aIQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n28si19527073pfi.109.2019.02.28.13.26.04; Thu, 28 Feb 2019 13:26:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733103AbfB1TCQ (ORCPT + 99 others); Thu, 28 Feb 2019 14:02:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50790 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbfB1TCQ (ORCPT ); Thu, 28 Feb 2019 14:02:16 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C570308B473; Thu, 28 Feb 2019 19:02:16 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-129.rdu2.redhat.com [10.10.121.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id E49211001DF2; Thu, 28 Feb 2019 19:02:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190228183923.5klzwli5zmeew54j@altlinux.org> References: <20190228183923.5klzwli5zmeew54j@altlinux.org> <20190224060828.2527-5-vt@altlinux.org> <20190224060828.2527-1-vt@altlinux.org> <14843.1551377934@warthog.procyon.org.uk> To: Vitaly Chikunov Cc: dhowells@redhat.com, Herbert Xu , Mimi Zohar , linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 04/10] crypto: akcipher - new verify API for public key algorithms MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17532.1551380529.1@warthog.procyon.org.uk> Date: Thu, 28 Feb 2019 19:02:09 +0000 Message-ID: <17533.1551380529@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 28 Feb 2019 19:02:16 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org | > It's not clear that sig->digest is guaranteed to be kmalloc memory. Well, public_key_signature_free() will go bang if it's not kfree'able. David