Received: by 2002:ac0:93d5:0:0:0:0:0 with SMTP id f21csp1147563imf; Thu, 28 Feb 2019 13:50:10 -0800 (PST) X-Google-Smtp-Source: AHgI3IajiTkZPT/PYa/AEz9Ydg4K/IeX5HV352HJkvwBarn78GqHGROxqMD3ATXA78lR4vth6YGp X-Received: by 2002:aa7:8a81:: with SMTP id a1mr1838720pfc.246.1551390610377; Thu, 28 Feb 2019 13:50:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551390610; cv=none; d=google.com; s=arc-20160816; b=SPZdmCsqgsG/fzZvLwEOs1XirROu+UgXBpoU5isGV5oN0/9NLbO28IQcZ99GL4sPPr TwKp1QpzceStSosgjkMdc+ON3zHCWHl2QVskHVAM/Zh6HLVajpApTZRpVFj8zyI813/Y 4oeIt7UTh9JK8C6e8YXp1kXLe05Eq0mNcl5pJnG6ln0eWyCiXgLI5SzYgrcgyajcoUVz LNqMj4bBgh7GlYADrms5hOLils28uhZOWSnr6bEfUUCXpxrNz4Vv0bTEEsHJWrFQydbD dZvzVQHXjT5ERqTzfpJzOMjvlZFWQSYlV85Pk8Eex7V0IWVpgp1AvJkuMmMisxdb6DIL WkUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=rR8WfbcKj2S1XHHJT+qBmLc1zUgxzLCHrxxCmJzloMg=; b=bjd55gmu1QVu/NbKdz0o1ltz4PiXzQKp0C6A5iVv7DI/lOIXezIli5wHnzG2MAc7St kXxbQMFtRMBN6A/lpbkIzyW4PeTSfe33m1ul4v6OFGFOrY2CF0s9G/euKiUWVszbLUj3 v4i1ZQyX+SBZBkyadY52zLVl0cTiFgPOQXkd3cJYuhl3tqkWOIX21fXU4ncmGPM61Asi CQWVCnj3ffQiO8HKBmeUDsHaSZcwYt9g4EX3xdaTRYWkV2kE5ZXNwhO7tCWPdOkzjx/X YuKesyTEwSKNi4UzuYG0sxs4aLNPFhSqWr7gBG0AFfdeV7i9rPLTPVBCxPELojxXxamS eACw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s21si17279647pgv.299.2019.02.28.13.49.54; Thu, 28 Feb 2019 13:50:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733042AbfB1UN7 (ORCPT + 99 others); Thu, 28 Feb 2019 15:13:59 -0500 Received: from mx0a-002e3701.pphosted.com ([148.163.147.86]:33250 "EHLO mx0a-002e3701.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726088AbfB1UN7 (ORCPT ); Thu, 28 Feb 2019 15:13:59 -0500 Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1SKAxUB000934; Thu, 28 Feb 2019 20:13:53 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0a-002e3701.pphosted.com with ESMTP id 2qxjw6u2tx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 28 Feb 2019 20:13:52 +0000 Received: from g4t3433.houston.hpecorp.net (g4t3433.houston.hpecorp.net [16.208.49.245]) by g9t5009.houston.hpe.com (Postfix) with ESMTP id D146D66; Thu, 28 Feb 2019 20:13:51 +0000 (UTC) Received: from misato.americas.hpqcorp.net (unknown [10.34.82.176]) by g4t3433.houston.hpecorp.net (Postfix) with ESMTP id 1AE5347; Thu, 28 Feb 2019 20:13:51 +0000 (UTC) From: Toshi Kani To: dan.j.williams@intel.com Cc: linux-nvdimm@lists.01.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Toshi Kani , "Rafael J. Wysocki" , Robert Elliott Subject: [PATCH] update NFIT flags error message Date: Thu, 28 Feb 2019 13:12:18 -0700 Message-Id: <20190228201218.12501-1-toshi.kani@hpe.com> X-Mailer: git-send-email 2.17.2 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-02-28_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=568 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902280136 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ACPI NFIT flags field reports major errors on NVDIMM, which need user's attention. Update the current log to a proper error message with dev_err(). The current message string is kept for grep-compatibility. Signed-off-by: Toshi Kani Cc: Dan Williams Cc: "Rafael J. Wysocki" Cc: Robert Elliott --- drivers/acpi/nfit/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index e18ade5d74e9..143a77704481 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -2050,7 +2050,7 @@ static int acpi_nfit_register_dimms(struct acpi_nfit_desc *acpi_desc) if ((mem_flags & ACPI_NFIT_MEM_FAILED_MASK) == 0) continue; - dev_info(acpi_desc->dev, "%s flags:%s%s%s%s%s\n", + dev_err(acpi_desc->dev, "Error found in NVDIMM %s flags:%s%s%s%s%s\n", nvdimm_name(nvdimm), mem_flags & ACPI_NFIT_MEM_SAVE_FAILED ? " save_fail" : "", mem_flags & ACPI_NFIT_MEM_RESTORE_FAILED ? " restore_fail":"",