Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190228194812.30929-1-louis@kragniz.eu>
In-Reply-To: <20190228194812.30929-1-louis@kragniz.eu>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 28 Feb 2019 12:45:27 -0800
Message-ID: <CAKwvOdkxcrNhEhgoTjZLOUwocqybS=fOr8vUgQVD6vCFMgcS9w@mail.gmail.com>
Subject: Re: [PATCH] vfio/pci: use correct format characters
To:     Louis Taylor <louis@kragniz.eu>
Cc:     alex.williamson@redhat.com, aik@ozlabs.ru, kvm@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        clang-built-linux@googlegroups.com,
        Jon Flatley <jflat@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 28, 2019 at 11:49 AM Louis Taylor <louis@kragniz.eu> wrote:
>
> When compiling with -Wformat, clang emits the following warnings:
>
> drivers/vfio/pci/vfio_pci.c:1601:5: warning: format specifies type
>       'unsigned short' but the argument has type 'unsigned int' [-Wformat]
>                                 vendor, device, subvendor, subdevice,
>                                 ^~~~~~
>
> drivers/vfio/pci/vfio_pci.c:1601:13: warning: format specifies type
>       'unsigned short' but the argument has type 'unsigned int' [-Wformat]
>                                 vendor, device, subvendor, subdevice,
>                                         ^~~~~~
>
> drivers/vfio/pci/vfio_pci.c:1601:21: warning: format specifies type
>       'unsigned short' but the argument has type 'unsigned int' [-Wformat]
>                                 vendor, device, subvendor, subdevice,
>                                                 ^~~~~~~~~
>
> drivers/vfio/pci/vfio_pci.c:1601:32: warning: format specifies type
>       'unsigned short' but the argument has type 'unsigned int' [-Wformat]
>                                 vendor, device, subvendor, subdevice,
>                                                            ^~~~~~~~~
>
> drivers/vfio/pci/vfio_pci.c:1605:5: warning: format specifies type
>       'unsigned short' but the argument has type 'unsigned int' [-Wformat]
>                                 vendor, device, subvendor, subdevice,
>                                 ^~~~~~
>
> drivers/vfio/pci/vfio_pci.c:1605:13: warning: format specifies type
>       'unsigned short' but the argument has type 'unsigned int' [-Wformat]
>                                 vendor, device, subvendor, subdevice,
>                                         ^~~~~~
>
> drivers/vfio/pci/vfio_pci.c:1605:21: warning: format specifies type
>       'unsigned short' but the argument has type 'unsigned int' [-Wformat]
>                                 vendor, device, subvendor, subdevice,
>                                                 ^~~~~~~~~
>
> drivers/vfio/pci/vfio_pci.c:1605:32: warning: format specifies type
>       'unsigned short' but the argument has type 'unsigned int' [-Wformat]
>                                 vendor, device, subvendor, subdevice,
>                                                            ^~~~~~~~~
> The types of these arguments are unconditionally defined, so this patch
> updates the format character to the correct ones for unsigned ints.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Louis Taylor <louis@kragniz.eu>

Thanks for the patch! LGTM
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>  drivers/vfio/pci/vfio_pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index a25659b5a5d1..3fa20e95a6bb 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -1661,11 +1661,11 @@ static void __init vfio_pci_fill_ids(void)
>                 rc = pci_add_dynid(&vfio_pci_driver, vendor, device,
>                                    subvendor, subdevice, class, class_mask, 0);
>                 if (rc)
> -                       pr_warn("failed to add dynamic id [%04hx:%04hx[%04hx:%04hx]] class %#08x/%08x (%d)\n",
> +                       pr_warn("failed to add dynamic id [%04x:%04x[%04x:%04x]] class %#08x/%08x (%d)\n",
>                                 vendor, device, subvendor, subdevice,
>                                 class, class_mask, rc);
>                 else
> -                       pr_info("add [%04hx:%04hx[%04hx:%04hx]] class %#08x/%08x\n",
> +                       pr_info("add [%04x:%04x[%04x:%04x]] class %#08x/%08x\n",
>                                 vendor, device, subvendor, subdevice,
>                                 class, class_mask);
>         }
> --
> 2.20.1
>


-- 
Thanks,
~Nick Desaulniers