Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2425imb; Thu, 28 Feb 2019 14:07:13 -0800 (PST) X-Google-Smtp-Source: APXvYqzqBXQW9tcbhEh0A9Z7est3AwRhhfUOBDnJGbNoyhTLH5CUAuGMkg7bl/E8Fg+dkf4GeiJo X-Received: by 2002:a17:902:8d97:: with SMTP id v23mr1674441plo.274.1551391633775; Thu, 28 Feb 2019 14:07:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551391633; cv=none; d=google.com; s=arc-20160816; b=jta4V+E7YZWFqD3slXaJWI4qVpzxacpyCGcDwGExSj6wvh9B7dpqPpzNAiuxjqL7aL xqO1S3QKBN40siMEDUWxwB6E90EVOXGGc598vbJzZHIGA1E5KvIy81T8P+yrbS4yYNE6 SCQmgHsLGVfEc5dLrqC3x/3ikqPkTy8XgHC+2mDEZIDsy8UgzUoF9owMB99TRVDJFg9P y7P7gEGX/R0IZ0dMI+UqvXcy8BXtV3Z7w/eW7P7DR2g3Zx1wPAUv4kzOnbqfel4p+NuE m/Pnvfc+cy//s40vOuF85ZnrvdylF/2q24iYahxW1mBiXliMx+Z+oRJeDb3Kh6J/FPWt pAeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=Nv3u0G/V3fQnw0uOpLM1knoRv2ExvBRHpS5Vngv0uhI=; b=cBo91hU8WD5O3m99pBOmgXopZfbpixOn7uYYYsgxzrS0UH/NOJVO01/k4rye/4suj6 /yVwjYPlbFZ8TpG8hWsbc3Xo2JDLDRa0Pf66s60iUoVfLwIYJeCnh5Co+ECRBty5agSL 9B2aNfiUJv5wvb3puYuNU0E4reMbTrcP/63wbe5LvrX/6NUkgaUqQi3uf7OWG3Hvht+H eWM7X/Cv031SJofms1V/Hm9Uh6LNixyk7GCpc6RpQp0au7NB0miEBuSFlhBowXdz1u7f DlpqizLx1H3YbD9ixkl87tHc9bgMJ0tOFyNyy/rVWZdknffmJm6WpdEJO+zTvomAXsVS j8Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Rb+5Dvng; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r187si14036089pfr.124.2019.02.28.14.06.56; Thu, 28 Feb 2019 14:07:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=Rb+5Dvng; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388322AbfB1VDZ (ORCPT + 99 others); Thu, 28 Feb 2019 16:03:25 -0500 Received: from mail-it1-f193.google.com ([209.85.166.193]:36453 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726414AbfB1VDZ (ORCPT ); Thu, 28 Feb 2019 16:03:25 -0500 Received: by mail-it1-f193.google.com with SMTP id v83so17972626itf.1 for ; Thu, 28 Feb 2019 13:03:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Nv3u0G/V3fQnw0uOpLM1knoRv2ExvBRHpS5Vngv0uhI=; b=Rb+5Dvngpl3lnByRKyvcQQo4lDFOSdougL9iFYjKQFlnbhAoX1dxToOrZNy/UA/HOm fYAllvWj8g7D0pvBMl/vXcjOasNTdOgGyZd+nWadMpVOYgehNlcmZjHkNEj5OBNvTwhb KxQ5zyfz75P+9bhDcyLaprX0VKay00LLlYU0HZmDIrdbW9W9S4OzI+ksWGPi5gQ/n7S4 4hBNLL0DJhnJjBtkH8uE651Bo0JlhcK7XQWbogdZQDREgrT8IQgOrSM3dQ9KyJDmGUN1 5p/j/cA9wv26BIUS2WDdH9iPTjjJfltUPsCHTcNeow3ttK2J1h1dPC9rGo3GCfbfhzWT nasw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Nv3u0G/V3fQnw0uOpLM1knoRv2ExvBRHpS5Vngv0uhI=; b=YlJ7Ay5UOz+iXtysiKZBFapfJiB42df7zvCSV0MnQOogxoHiBoM0Xsk71+S1HLnyy6 lSHCY+rcOBlQrP4k7Ooq6j6T+EuK/TzUph6TD3XCSM6JEqvAglLh0u5FBudRH4lgobyW gMb7BFO55wtwop9ZVVQpylGlhRyt5lj6bQJOuww2PKfibl0neZt5jYON4k3rZe2KAGR3 zPuTl/GhjkeVdMJhFH4hfYDzGBV8DsH9iJvcXftr84YNEu15simkl/Wh+O3i8fAOc1RS vb3+vmrx7JAymJ3VxuLHY9njvbN9V4x1upAqPt2QVCSAnx9zqeHBkqeCnWtnGyh6I5Bk BRdQ== X-Gm-Message-State: APjAAAVE/IyCSbBu03wxmc5iSSeZwSFoGZcV7CS2jq7CJxaeSlVuEQoU RaHME1uJv2VPMPTNYNVN1/53rQ== X-Received: by 2002:a02:7124:: with SMTP id n36mr706400jac.122.1551387804251; Thu, 28 Feb 2019 13:03:24 -0800 (PST) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id u82sm3286213itb.18.2019.02.28.13.03.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 13:03:23 -0800 (PST) Subject: Re: [PATCH] null_blk: fix checking for REQ_FUA To: Heinz Mauelshagen Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org References: <154589c8c1b22879dfc03aec4555793329d5ce83.1550861849.git.heinzm@redhat.com> From: Jens Axboe Message-ID: Date: Thu, 28 Feb 2019 14:03:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <154589c8c1b22879dfc03aec4555793329d5ce83.1550861849.git.heinzm@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/22/19 12:00 PM, Heinz Mauelshagen wrote: > null_handle_bio() erroneously uses the bio_op macro > which masks respective request flag bits including REQ_FUA > out thus failing the check. > > Fix by checking bio->bi_opf directly. Thanks, applied. -- Jens Axboe