Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp9336imb; Thu, 28 Feb 2019 14:18:27 -0800 (PST) X-Google-Smtp-Source: APXvYqzTQyaDRnqXs5pu6JkbAHy7kxkZ5ll9x0fFSBe2o1wz9DjA4exwO7pSphiWE18TYYOm9ecd X-Received: by 2002:a63:20a:: with SMTP id 10mr1458224pgc.346.1551392307822; Thu, 28 Feb 2019 14:18:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551392307; cv=none; d=google.com; s=arc-20160816; b=zXwM5ceyXusOc357yMT9+pZX9jWtWO+1otqhKOHzCXMbIGwG6hYF7Cwe0Q2AABi9m8 zmhkoRb43Hrt6aqMDY2nO94djmWo4U+FoDH4Ehy/QcEWo902/3U9Z831W0VTuNbqCXHW dNa5/RnouwAx8+gCgkIMM7++pbArn2k9+PNFwnNs2ZNc6d02/VuuM4ZC0wBUvdcoY9EH chaDTg3pmPQJ6snKEKHH3jkJR2qAawQkH/5OIOLrCkd73wQCiZBn+gstAxXuQCJQvK5P zxH1X2An/8ILeMskCLLSBXlIqoZb0Cw1nNpsN/nOYzw3as8azS5Q8GawJQfM38oKEPv4 yjdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=6cUjHW1IY4DGgHscyLOzgoUOnldde6PgR4ggd0r1IB0=; b=nwTK/gKJQ/eYHMbJhKG09o2Ze5iXcvk2nzPcvmKmdtNyVwnbHKHLqSnceZHNaCQJJY rFbI1anKhWdpgU0YaW5miakvQ/K5DiJc2L3Y9F/w9dTnfc6oQ4bfueXjvfq6OoEk9Cid e969C52oo2cQiA1SsRWSnjudwatIVI2sYmUIt+sL7P3tOCJi7Q8yPpu8H+1TWjP57HDF Xn7jxRAGjgUV4bYZgkudpyTI1bInfYy2OT9rEm8xYkAYtUMZ9TTPifAu0mrFAJKsZdRj qBil/r18Sjf/1SsJHeJB9HMtO3o9b34cw2AF1zrzcc9uEdlDqf2uA3sNEjKrnwgpGSF3 llqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w34si10331471pla.135.2019.02.28.14.18.12; Thu, 28 Feb 2019 14:18:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732866AbfB1Vp4 (ORCPT + 99 others); Thu, 28 Feb 2019 16:45:56 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:39218 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbfB1Vp4 (ORCPT ); Thu, 28 Feb 2019 16:45:56 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1F22914BFF7E2; Thu, 28 Feb 2019 13:45:55 -0800 (PST) Date: Thu, 28 Feb 2019 13:45:52 -0800 (PST) Message-Id: <20190228.134552.2241468473442628824.davem@davemloft.net> To: antoine.tenart@bootlin.com Cc: linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com Subject: Re: [PATCH net-next 14/15] net: mvpp2: set the XPCS and MPCS in reset when not used From: David Miller In-Reply-To: <20190228212312.GI4359@kwain> References: <20190228132128.30154-15-antoine.tenart@bootlin.com> <20190228.104051.1946425715498350215.davem@davemloft.net> <20190228212312.GI4359@kwain> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Feb 2019 13:45:55 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Antoine Tenart Date: Thu, 28 Feb 2019 22:23:12 +0100 > Right. But here we do need priv to be assigned first in order to assign > mpcs and xpcs. Then put the latter assignments into the body of the function.