Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp10911imb; Thu, 28 Feb 2019 14:21:18 -0800 (PST) X-Google-Smtp-Source: APXvYqySFpMA37EeIORT6/yWVP/aT298cHOcgFN9/abJsKJjijNYQ+2qCK7pi92z0Ltyv4ImDyL0 X-Received: by 2002:a63:f648:: with SMTP id u8mr1415135pgj.91.1551392478748; Thu, 28 Feb 2019 14:21:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551392478; cv=none; d=google.com; s=arc-20160816; b=XNtW/uAdRaZRo3c5qbkhDHLfdMKSbV5ad8NyJlW3R2ks7gF8zApkFrTqdAtf90VM1O qHdYG3ubQ5ey5Wu2Ehnu5mNquG9tYQZMPw2dCcfeQCYcdH4ibAaGpZI4hM4kwwlQ+PCe XccT4jj0qzSNyKALQTqkPiYusJWjDTEt21wyQuWqI0+DN1+7xVwD6WGsDUgLKoQ2zULY rYF59qPtCVHQcDrTAa7+kMkX2Nd96d2ltA3TGI3S6kODpZK3OvXNyzk0+fxLYAOWImFW 6tdLDRAYZmRIsX6Bg6i4grUDU35sHSZHQcbgpC5OnYfuEk6b9BBrLaQRg78LSjhuEK4v 0uVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=lp0YkothahhdP4oQqOkXRwHxr5NEdq2Tk+d6kbvXpvs=; b=NCmMeqclOUae4jSw5nZQkMKpJTh6S5lc7G9coK8EmTExnwES4lMJhv+qAib1OOZZRT euoEEn1m0l4Ro/CwCP1baUqdSc5bgSaLlUgZtSBmn0Mx9rOuzQAmg0ZheFu8B7K24rjz ODOZI9QWqJ+Tj0XHk+R0hPHAbqUfYyYcDtSl6eTK2GkaghLv5Df0MIgmw3AQ5lr6XXgV qVf3PlY6xqv5vFhrYArP4tapmWPkx0fCei4UOV/JXQhG+9ulXTFEaatuSDNHpvNK/J1Y 1H1AhE+aKhRv7gJySc5pehdUCmg6tT2IODJ+hNHM9RwOOZhiIWux0M1KZcgjQikRFUHk A89A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=CD2TxwtF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si18363621pfe.1.2019.02.28.14.21.01; Thu, 28 Feb 2019 14:21:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=CD2TxwtF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728480AbfB1WLi (ORCPT + 99 others); Thu, 28 Feb 2019 17:11:38 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:17552 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbfB1WLi (ORCPT ); Thu, 28 Feb 2019 17:11:38 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 28 Feb 2019 14:11:37 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 28 Feb 2019 14:11:37 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 28 Feb 2019 14:11:37 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 28 Feb 2019 22:11:37 +0000 Subject: Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly To: Vlastimil Babka , Andrey Ryabinin , Andrew Morton CC: Johannes Weiner , Rik van Riel , , , Michal Hocko , Mel Gorman References: <20190228083329.31892-1-aryabinin@virtuozzo.com> <20190228083329.31892-2-aryabinin@virtuozzo.com> <44ffadb4-4235-76c9-332f-680dda5da521@nvidia.com> <67a79bb9-12b5-e668-abb1-ef91a9cbfea8@suse.cz> X-Nvconfidentiality: public From: John Hubbard Message-ID: <1f978daf-a037-e7e8-079f-80b421e663e1@nvidia.com> Date: Thu, 28 Feb 2019 14:11:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <67a79bb9-12b5-e668-abb1-ef91a9cbfea8@suse.cz> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8" Content-Language: en-US-large Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1551391897; bh=lp0YkothahhdP4oQqOkXRwHxr5NEdq2Tk+d6kbvXpvs=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=CD2TxwtFekB+bBed5i0C1P4DuD2v5dgZN5qqtiUld50Q948O/cWRv7yuw5gs/TDEQ FR9v7o8SGJLGMEzBTYMb4VC1rjPp+RfJztcpEXyfH7kqwO2HurvKBogeltDkmhKdyV jSVGop4Ot6AWpm3d23F7Luig9XGcMjxBRgPac0ciDvobI8UI7gU8vqQoWxtvdTjZNn /uXzPbJqd8HuQYuqMhLg2j9AmqQVDYadRch9zSM2P/VIzyK0ZSKQ/omIEN6VJ6YEz5 zbNC7GfJBfL7wTVavZe7xcODbD3Pe7sDxcfcQwTIdN/CMX5jcUeyM372zo+/Fkjkpw 21BdF8AWj+V1w== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/28/19 1:56 PM, Vlastimil Babka wrote: > On 2/28/2019 10:44 PM, John Hubbard wrote: >> Instead of removing that function, let's change it, and add another >> (since you have two cases: either a page* or a pgdat* is available), >> and move it to where it can compile, like this: >> >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 80bb6408fe73..cea3437f5d68 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -1167,6 +1167,16 @@ static inline pg_data_t *page_pgdat(const struct page *page) >> return NODE_DATA(page_to_nid(page)); >> } >> >> +static inline spinlock_t *zone_lru_lock(pg_data_t *pgdat) > > In that case it should now be named node_lru_lock(). zone_lru_lock() was a > wrapper introduced to make the conversion of per-zone to per-node lru_lock smoother. > Sounds good to me. thanks, -- John Hubbard NVIDIA