Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 28 Feb 2019 13:53:19 -0600
From:   Rob Herring <robh@kernel.org>
To:     Baolin Wang <baolin.wang@linaro.org>
Cc:     gregkh@linuxfoundation.org, jslaby@suse.com, mark.rutland@arm.com,
        orsonzhai@gmail.com, zhang.lyra@gmail.com, broonie@kernel.org,
        lanqing.liu@unisoc.com, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: serial: sprd: Add dma properties to
 support DMA mode
Message-ID: <20190228195319.GA13133@bogus>
References: <cover.1550560916.git.baolin.wang@linaro.org>
 <8f0a032f9bcce28bb0d147f9646950f64fc22a74.1550560916.git.baolin.wang@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8f0a032f9bcce28bb0d147f9646950f64fc22a74.1550560916.git.baolin.wang@linaro.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 19, 2019 at 03:31:14PM +0800, Baolin Wang wrote:
> From: Lanqing Liu <lanqing.liu@unisoc.com>
> 
> This patch adds dmas and dma-names properties for the UART DMA mode.
> 
> Signed-off-by: Lanqing Liu <lanqing.liu@unisoc.com>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> ---
>  .../devicetree/bindings/serial/sprd-uart.txt       |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> index 6eb5863..9ac28f6 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> @@ -15,12 +15,18 @@ Required properties:
>    UART clock and source clock are optional properties, but enable clock
>    is required.
>  
> +Optional properties:
> +- dma-names: Should contain "tx" for transmit and "rx" for receive channels.

The order here doesn't match the example.

> +- dmas: A list of dma specifiers, one for each entry in dma-names.
> +
>  Example:
>  	uart0: serial@0 {
>  		compatible = "sprd,sc9860-uart",
>  			     "sprd,sc9836-uart";
>  		reg = <0x0 0x100>;
>  		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> +		dma-names = "rx", "tx";
> +		dmas = <&ap_dma 19 19>, <&ap_dma 20 20>;
>  		clock-names = "enable", "uart", "source";
>  		clocks = <&clk_ap_apb_gates 9>, <&clk_uart0>, <&ext_26m>;
>  	};
> -- 
> 1.7.9.5
>