Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] net: ipv6: check net in ip6_call_ra_chain
To:     David Miller <davem@davemloft.net>, fruggeri@arista.com
Cc:     yoshfuji@linux-ipv6.org, kuznet@ms2.inr.ac.ru, maxim@arista.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
References: <20190228190146.802CD95C016B@us180.sjc.aristanetworks.com>
 <20190228.130213.1481374802407995712.davem@davemloft.net>
From:   David Ahern <dsahern@gmail.com>
Message-ID: <171e33d9-ee82-6a62-693e-5d585e4eca28@gmail.com>
Date:   Thu, 28 Feb 2019 16:31:40 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190228.130213.1481374802407995712.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2/28/19 2:02 PM, David Miller wrote:
> From: fruggeri@arista.com (Francesco Ruggeri)
> Date: Thu, 28 Feb 2019 11:01:46 -0800
> 
>> ip6_call_ra_chain is called when IPv6 packet with Router Alert option
>> is forwarded.
>> It needs to check if the net of the socket is the same as the net of the
>> input device, otherwise the packet gets delivered to every IPv6 socket
>> listening for Router Alerts, no matter which network namespace it is in.
>>
>> Suggested-by: Maxim Martynov <maxim@arista.com>
>> Signed-off-by: Maxim Martynov <maxim@arista.com>
>> Signed-off-by: Francesco Ruggeri <fruggeri@arista.com>
> 
> Right now someone using such a tool does get all RAs in the system.
> 
> Your change not only breaks them, but also gives them no method by
> which to keep obtaining the same behavior.
> 
> I don't know what to do or suggest in this situation, but right now
> I'm putting this patch on hold.
> 

need an equivalent to NETLINK_LISTEN_ALL_NSID