Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190228220155.88124-1-cai@lca.pw>
In-Reply-To: <20190228220155.88124-1-cai@lca.pw>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Thu, 28 Feb 2019 15:43:12 -0800
Message-ID: <CALCETrW+p_PsdRfQh99JkPW2Zi6z_w4RqDnsK0=kU+D7RqeYzA@mail.gmail.com>
Subject: Re: [PATCH] x86/mm: fix "cpu" set but not used
To:     Qian Cai <cai@lca.pw>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, X86 ML <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 28, 2019 at 2:02 PM Qian Cai <cai@lca.pw> wrote:
>
> The commit a2055abe9c67 ("x86/mm: Pass flush_tlb_info to
> flush_tlb_others() etc") removed the unnecessary cpu parameter from
> uv_flush_tlb_others() but left an unused variable.
>
> arch/x86/mm/tlb.c: In function 'native_flush_tlb_others':
> arch/x86/mm/tlb.c:688:16: warning: variable 'cpu' set but not used
> [-Wunused-but-set-variable]
>    unsigned int cpu;
>                 ^~~
>

Acked-by: Andyt Lutomirski <luto@kernel.org>