Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 08/27] kexec_file: Restrict at runtime if the kernel is
 locked down
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Matthew Garrett <matthewgarrett@google.com>, jmorris@namei.org
Cc:     linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, dhowells@redhat.com
Date:   Thu, 28 Feb 2019 21:05:53 -0500
In-Reply-To: <20190228231203.212359-8-matthewgarrett@google.com>
References: <CACdnJuvW47m3JvEcuEX1bsr+L2Ht9LDn_iCuPbHLOoaohOFW4Q@mail.gmail.com>
         <20190228231203.212359-1-matthewgarrett@google.com>
         <20190228231203.212359-8-matthewgarrett@google.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-Id: <1551405953.10911.281.camel@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jiri,

Thank you for thinking about IMA.

On Thu, 2019-02-28 at 15:11 -0800, Matthew Garrett wrote:
> From: Jiri Bohac <jbohac@suse.cz>
> 
> When KEXEC_SIG is not enabled, kernel should not load images through
> kexec_file systemcall if the kernel is locked down unless IMA can be used
> to validate the image.

This patch is a partial solution, but it doesn't take into account the
architecture specific or custom policies.

Mimi

> [Modified by David Howells to fit with modifications to the previous patch
>  and to return -EPERM if the kernel is locked down for consistency with
>  other lockdowns]
> 
> Signed-off-by: Jiri Bohac <jbohac@suse.cz>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Reviewed-by: Jiri Bohac <jbohac@suse.cz>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> cc: Chun-Yi Lee <jlee@suse.com>
> cc: kexec@lists.infradead.org
> ---
>  include/linux/ima.h | 6 ++++++
>  kernel/kexec_file.c | 8 ++++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/include/linux/ima.h b/include/linux/ima.h
> index b5e16b8c50b7..b35ed0725a05 100644
> --- a/include/linux/ima.h
> +++ b/include/linux/ima.h
> @@ -127,4 +127,10 @@ static inline int ima_inode_removexattr(struct dentry *dentry,
>  	return 0;
>  }
>  #endif /* CONFIG_IMA_APPRAISE */
> +
> +static inline bool is_ima_kexec_appraise_enabled(void)
> +{
> +	return IS_ENABLED(CONFIG_IMA_APPRAISE_REQUIRE_KEXEC_SIGS);
> +}
> +
>  #endif /* _LINUX_IMA_H */
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index 67f3a866eabe..b4e938dff4be 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -239,6 +239,14 @@ kimage_file_prepare_segments(struct kimage *image, int kernel_fd, int initrd_fd,
>  		}
> 
>  		ret = 0;
> +		if (is_ima_kexec_appraise_enabled())
> +			break;
> +
> +		if (kernel_is_locked_down(reason)) {
> +			ret = -EPERM;
> +			goto out;
> +		}
> +
>  		break;
> 
>  		/* All other errors are fatal, including nomem, unparseable