Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190204150142.GA3900@jordon-HP-15-Notebook-PC> <CAFqt6zbWPn4H6ArYEecou0Ri79a6hQcYcBo8ZrjPfkxFJUV-UQ@mail.gmail.com>
In-Reply-To: <CAFqt6zbWPn4H6ArYEecou0Ri79a6hQcYcBo8ZrjPfkxFJUV-UQ@mail.gmail.com>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Fri, 1 Mar 2019 08:34:33 +0530
Message-ID: <CAFqt6zZ=9-xtHg_vuCQ2E+S91G6jD8CcK=Wr-OjYONO4+SnEmg@mail.gmail.com>
Subject: Re: [PATCHv2] media: videobuf2: Return error after allocation failure
To:     pawel@osciak.com, Marek Szyprowski <m.szyprowski@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>, mchehab@kernel.org,
        Nicolas Dufresne <nicolas@ndufresne.ca>
Cc:     linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Feb 11, 2019 at 7:42 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> On Mon, Feb 4, 2019 at 8:27 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >
> > There is no point to continuing assignment after memory allocation
> > failed, rather throw error immediately.
> >
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Any comment on this patch ?

If no further comment, can we get this patch in queue for 5.1 ?
>
> > ---
> > v1 -> v2:
> >         Corrected typo in change log.
> >
> >  drivers/media/common/videobuf2/videobuf2-vmalloc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/media/common/videobuf2/videobuf2-vmalloc.c b/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> > index 6dfbd5b..d3f71e2 100644
> > --- a/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> > +++ b/drivers/media/common/videobuf2/videobuf2-vmalloc.c
> > @@ -46,16 +46,16 @@ static void *vb2_vmalloc_alloc(struct device *dev, unsigned long attrs,
> >
> >         buf->size = size;
> >         buf->vaddr = vmalloc_user(buf->size);
> > -       buf->dma_dir = dma_dir;
> > -       buf->handler.refcount = &buf->refcount;
> > -       buf->handler.put = vb2_vmalloc_put;
> > -       buf->handler.arg = buf;
> >
> >         if (!buf->vaddr) {
> >                 pr_debug("vmalloc of size %ld failed\n", buf->size);
> >                 kfree(buf);
> >                 return ERR_PTR(-ENOMEM);
> >         }
> > +       buf->dma_dir = dma_dir;
> > +       buf->handler.refcount = &buf->refcount;
> > +       buf->handler.put = vb2_vmalloc_put;
> > +       buf->handler.arg = buf;
> >
> >         refcount_set(&buf->refcount, 1);
> >         return buf;
> > --
> > 1.9.1
> >