Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 1 Mar 2019 14:12:34 +0530
From:   Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@intel.com>
Cc:     lee.jones@linaro.org, bleung@chromium.org,
        enric.balletbo@collabora.com, groeck@chromium.org,
        linux-kernel@vger.kernel.org, gwendal@google.com,
        jettrink@chromium.org
Subject: Re: [PATCH v2] mfd: cros_ec: instantiate properly CrOS ISH MCU device
Message-ID: <20190301084234.GA632@intel.com>
References: <1551413171-27290-1-git-send-email-rushikesh.s.kadam@intel.com>
 <20190301072811.GH9224@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190301072811.GH9224@smile.fi.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Andy

On Fri, Mar 01, 2019 at 09:28:11AM +0200, Andy Shevchenko wrote:
> On Fri, Mar 01, 2019 at 09:36:11AM +0530, Rushikesh S Kadam wrote:
> > Integrated Sensor Hub (ISH) is also a MCU running EC
> > having feature bit EC_FEATURE_ISH. Instantiate it as
> > a special CrOS EC device with device name 'cros_ish'.
> 
> > v2
> > - Addressed review comments to term the CrOS EC device as a generic
> >   Integrated Sensor Hub. 
> 
> > +	/* The MCU is an Intel Integrated Sensor Hub */
> 
> This has to be adjusted as well. Intel ISH is just one of the example of ISHs.

Thanks for the catch

I submitted v3 with this fixed

Regards
Rushikesh

> 
> > +	EC_FEATURE_ISH = 40,
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

--