Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp367613imb; Fri, 1 Mar 2019 02:55:22 -0800 (PST) X-Google-Smtp-Source: APXvYqxWUqhL+27prw3gFm/ZbciEN7VLy3C09/tVyWFM1AEcjZa7qp+atTgnNXrdVUCh4sxVg9Na X-Received: by 2002:a17:902:2be8:: with SMTP id l95mr4880574plb.270.1551437722882; Fri, 01 Mar 2019 02:55:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551437722; cv=none; d=google.com; s=arc-20160816; b=JIv7pPwoHCCCd8mBaSxwRksDxL7O+0nmnp/ohK6En+3Qj513BglkbmqYteHtMQZ8C9 sNf6kxblGOhgr4T3DeJ52HNY0MJWZ3fMcipX23anPe562WtvMBKtlWavOVMJUfc8u3ff mzHshHk+W2/XdZNG/LzaUKDiMMiTHTKrbIVBOS/OhKyEFCgVR6lGXMGBwfR8FgzFGKKx RI+oUTKVp62bZNGj9bwPsrQT+X8rIuCGmiTofybOc3TIn9vrNWL7A4KiZ7KnI+fUVGt5 ZBfIL5FCQNu906jELVeMKpEnCnm4lQ7KRY9TyuZvluI9cmUDQsCwmS3lVEfA/dVluR5r mzuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=EBQ+nZsyDWJTzcOlo9GrDXg6rCUBjuuZJGksrqrehuE=; b=PsoQfJrn0NDJpG4PcgLPeo5FsJ642hYP01xLuM3LqxPcRFI45ZxDBCv5+DiCRjVNcQ TWGBTr9b1jLa87Z9LF5ahhibGbGLGc7B1xWAUPfZAaHHx8LgcU/+MbrB/PZe9LwUxd8W 3RMvFsMhzF2XqajAIx+TFr26WY774jQ/l3+HxLKQxbRwI1X3gb/n0Gf3HKAt6lDoW9sT REQBSmxRqrmEEZEgPl18bjnVNlzYzpLm8MDON5Gq+wcdY3ZkJcdftKHjYAFW8ucbohfO QfpuUBL/0A/Pz9UtBUSFCE8kkBxIbEJU3AmGsDOktnP6OoWXPGCsKgbvSFO6k/JAzqUM LDxQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v4si16530922pff.172.2019.03.01.02.55.07; Fri, 01 Mar 2019 02:55:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728305AbfCAKvA (ORCPT + 99 others); Fri, 1 Mar 2019 05:51:00 -0500 Received: from relay.sw.ru ([185.231.240.75]:41386 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727782AbfCAKu7 (ORCPT ); Fri, 1 Mar 2019 05:50:59 -0500 Received: from [172.16.25.12] by relay.sw.ru with esmtp (Exim 4.91) (envelope-from ) id 1gzfkk-00048B-Hz; Fri, 01 Mar 2019 13:50:54 +0300 Subject: Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly To: John Hubbard , Andrew Morton Cc: Johannes Weiner , Vlastimil Babka , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Mel Gorman References: <20190228083329.31892-1-aryabinin@virtuozzo.com> <20190228083329.31892-2-aryabinin@virtuozzo.com> <44ffadb4-4235-76c9-332f-680dda5da521@nvidia.com> From: Andrey Ryabinin Message-ID: <186bf66b-fec5-a614-3ffd-64b8d7660fe5@virtuozzo.com> Date: Fri, 1 Mar 2019 13:51:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: <44ffadb4-4235-76c9-332f-680dda5da521@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/1/19 12:44 AM, John Hubbard wrote: > On 2/28/19 12:33 AM, Andrey Ryabinin wrote: >> We have common pattern to access lru_lock from a page pointer: >> zone_lru_lock(page_zone(page)) >> >> Which is silly, because it unfolds to this: >> &NODE_DATA(page_to_nid(page))->node_zones[page_zonenum(page)]->zone_pgdat->lru_lock >> while we can simply do >> &NODE_DATA(page_to_nid(page))->lru_lock >> > > Hi Andrey, > > Nice. I like it so much that I immediately want to tweak it. :) > > >> Remove zone_lru_lock() function, since it's only complicate things. >> Use 'page_pgdat(page)->lru_lock' pattern instead. > > Here, I think the zone_lru_lock() is actually a nice way to add > a touch of clarity at the call sites. How about, see below: > > [snip] > >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >> index 2fd4247262e9..22423763c0bd 100644 >> --- a/include/linux/mmzone.h >> +++ b/include/linux/mmzone.h >> @@ -788,10 +788,6 @@ typedef struct pglist_data { >> >> #define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) >> #define node_end_pfn(nid) pgdat_end_pfn(NODE_DATA(nid)) >> -static inline spinlock_t *zone_lru_lock(struct zone *zone) >> -{ >> - return &zone->zone_pgdat->lru_lock; >> -} >> > > Instead of removing that function, let's change it, and add another > (since you have two cases: either a page* or a pgdat* is available), > and move it to where it can compile, like this: > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 80bb6408fe73..cea3437f5d68 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1167,6 +1167,16 @@ static inline pg_data_t *page_pgdat(const struct page *page) > return NODE_DATA(page_to_nid(page)); > } > > +static inline spinlock_t *zone_lru_lock(pg_data_t *pgdat) > +{ > + return &pgdat->lru_lock; > +} > + I don't think wrapper for a simple plain access to the struct member is reasonable. Besides, there are plenty of "spin_lock(&pgdat->lru_lock)" even without this patch, so for consistency reasons &pgdat->lru_lock seems like a better choice to me. Also "&pgdat->lru_lock" is just shorter than: "node_lru_lock(pgdat)" > +static inline spinlock_t *zone_lru_lock_from_page(struct page *page) > +{ > + return zone_lru_lock(page_pgdat(page)); > +} > + I don't think such function would find any use. Usually lru_lock is taken to perform some manipulations with page *and* pgdat, thus it's better to remember page_pgdat(page) in local variable.