Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262121AbUCQWny (ORCPT ); Wed, 17 Mar 2004 17:43:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262122AbUCQWny (ORCPT ); Wed, 17 Mar 2004 17:43:54 -0500 Received: from ns.suse.de ([195.135.220.2]:55510 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S262121AbUCQWnx (ORCPT ); Wed, 17 Mar 2004 17:43:53 -0500 Subject: Re: 2.6.4-mm2 From: Chris Mason To: Andrew Morton Cc: daniel@osdl.org, linux-kernel@vger.kernel.org, linux-aio@kvack.org In-Reply-To: <20040317123324.46411197.akpm@osdl.org> References: <20040314172809.31bd72f7.akpm@osdl.org> <1079461971.23783.5.camel@ibm-c.pdx.osdl.net> <1079474312.4186.927.camel@watt.suse.com> <20040316152106.22053934.akpm@osdl.org> <20040316152843.667a623d.akpm@osdl.org> <20040316153900.1e845ba2.akpm@osdl.org> <1079485055.4181.1115.camel@watt.suse.com> <1079487710.3100.22.camel@ibm-c.pdx.osdl.net> <20040316180043.441e8150.akpm@osdl.org> <1079554288.4183.1938.camel@watt.suse.com> <20040317123324.46411197.akpm@osdl.org> Content-Type: text/plain Message-Id: <1079563568.4185.1947.camel@watt.suse.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Wed, 17 Mar 2004 17:46:08 -0500 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 27 On Wed, 2004-03-17 at 15:33, Andrew Morton wrote: > Chris Mason wrote: > > > > [ data not getting flushed ] > > > > Ummm, this might help: > > Pedant. > ;-) wait_on_page_writeback_range() does a pagevec_lookup_tag on min(end - index + 1, (pgoff_t)PAGEVEC_SIZE) Which translates to: (unsigned long)-1 - 0 + 1, which is 0. It doesn't look like anyone is using the range feature of this function, can we make it just wait on all the writeback pages? -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/