Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp652694imb; Fri, 1 Mar 2019 10:14:30 -0800 (PST) X-Google-Smtp-Source: APXvYqy6IyBabis0u1rgWADZeW/XsTRZGQvn5XkENWm5RDKXzHAP7hr3G5UkkDkEVmY6lFOBgP7U X-Received: by 2002:a63:694a:: with SMTP id e71mr1594894pgc.129.1551464070019; Fri, 01 Mar 2019 10:14:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551464070; cv=none; d=google.com; s=arc-20160816; b=BX5OSGNlEaUYnZv2Ctxm+yFm5neY/drHhwIokQowPEz8XwjmJ0sw5tWGdPsDzyFzha h5TBd6ZT4TnnQxwIZj626AonLlE+CvfoYtVlTRmBylQbqANQXcmcdqzaYVA6bDbnwQih U2W0SgowkaVN49WaqpvrZ1WSFRTECd7ZY6/msRxbTr5LEkPJpC7XO31kTx9UUeEMA5RU DdWka59vXUDc807CaabDFD7VzoRBbC0gDl8/EVyohC53XNMQbpif4dFayqYjVFVerKvu D7GctlDOBD7eRbyHYB90iz9Qgl/SczuJlZvfwT2nZh62KCPhmdioPvPwUDjLCzbt11I1 W1Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:references:cc:to:from:subject :dkim-signature; bh=HlB4DS54GFijftk0TlQuUAHn5HmlOlT3HdXeBRlJrdQ=; b=bOivYplBWjo65plrIRKfIvLXsbX03NoRofcZVXGNqpJgWEOhuRdKZpZh9zG86FYDHs aKTm7GsREygOzkP/lVQ/7SNHzKIzgtN00adgiIWXU61ZwxJP7RuN74SjKPpZsDLf+Uud 4qW0dxo/h228BwoEhpoI1zcWMXZwmVXI9GtE3NCE+OSYvBzUvAfF26dPg+n/pebFdwCr b9NxtfzhH2D1qdU+XHlWXSFQxYEWezZZDOLIS1mqSDIaEhsh2xJ83u54UiCzEx3U+02n 6cwqDnRTiRxjeQokMiCwNuK3zSz+dyY1l9vbrGHxwGfgHSFv0/IAXPTpA1E6hhES7PZJ ciNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Tqj3YSzN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l93si21770854plb.433.2019.03.01.10.14.15; Fri, 01 Mar 2019 10:14:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Tqj3YSzN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389632AbfCARyM (ORCPT + 99 others); Fri, 1 Mar 2019 12:54:12 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:37093 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728264AbfCARyL (ORCPT ); Fri, 1 Mar 2019 12:54:11 -0500 Received: by mail-pl1-f196.google.com with SMTP id q3so11823969pll.4; Fri, 01 Mar 2019 09:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HlB4DS54GFijftk0TlQuUAHn5HmlOlT3HdXeBRlJrdQ=; b=Tqj3YSzNiekIDAqnzz9Pm7NOMco9gWYo/OTwrtEYLEFsRaga8QRElCymPnkOSBBADg s5UIIN9YllBh/mm+dG0FPo5AcyZIC280iKJQq+e9tsHuKeiECqc01E4wZPNftVtMlKCr VuxBEsbFzKYi3t/EqX+Y0CdCDrOhn3w+qCVFuDRKZQCgdcLi7sf8hYQw/JlJcaArJdEw y/d1x6mqoUFXPbdUgEmSMieClwmnLw+khz4wSGOM57qMQnJYpLr2YKBHqPGQcoy95tJ2 dGT/r9d6NEU0GI4ci9flYQ0+A4tzdsOx6J8DYpAxeZk/8LkuMIOD38rfg+JGnUxGsmA7 fNiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=HlB4DS54GFijftk0TlQuUAHn5HmlOlT3HdXeBRlJrdQ=; b=Zoh1V0e0NhzYRVrKywnzZqpw0f2wLvs3byF66pEGHV+CNUSyWy2moR0WFihmpvsm2x ePOIhRj4US/vdJe5Lix+w/raAyA2JUdRR6A3cdqBZaLBemb/O0WXha028aaRC071S72y X3FeDstqGfozULfTrYPfNELvxYMQVqt+rnnWQTK/qAtj6UUqwFFrCVKzMbmpSxTLU9AG CgfuVBGmg0Eu8P/VmFB3B85RgC1x9i8rxaVElZ2Iz0k0VXpqRmdw9HS6ucgmxDY4KxOY HX/GAgVUmYe3MfY1EYUgTtsGdzLgQ9ZIi4OzWUWiQS5ImOSHveyqccSIn0SGGV8iXavO BO8A== X-Gm-Message-State: APjAAAXi0wrVWTnOrY+y6TZa71PHSaKWjNgWXd+npBhP60VynnPh8758 o8beX/M+De7fomA8oC0hKm3vDpBs X-Received: by 2002:a17:902:8bc6:: with SMTP id r6mr6779421plo.235.1551462850393; Fri, 01 Mar 2019 09:54:10 -0800 (PST) Received: from [10.67.50.0] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id m6sm22727846pfa.115.2019.03.01.09.54.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 09:54:09 -0800 (PST) Subject: Re: [PATCH net-next] net: dsa: Do not configure VLAN ID 0 From: Florian Fainelli To: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= , Heiner Kallweit , "David S. Miller" Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , open list References: <20190228234936.1593-1-f.fainelli@gmail.com> <5cfd1cbc-1ba4-2274-841a-4285db72afa4@ysoft.com> <2f23dc48-a042-4fcf-cc5b-11d247061239@gmail.com> Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Fri, 1 Mar 2019 09:54:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <2f23dc48-a042-4fcf-cc5b-11d247061239@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/1/19 9:52 AM, Florian Fainelli wrote: [snip] >> Tested-by: Michal Vokáč >> >> I am not sure what was the original problem as I could not find the >> thread where Heiner reported the issue but with the latest version >> next-20190228 I get this error with QCA8334 switch: > > Thanks Michal. There is still a lingering issue though, because we > currently skip the prepare phase (we don't have a switchdev_trans > structure that would make sense here), we are not checking that the > underlying switch device driver does actually support > port_vlan_add/port_vlan_del, and qca8k currently does not. I will submit > a v2 patch that also takes care of that. David, please discard this version, I will submit a version that properly emulates the prepare/commit phase such that no assumptions are broken, this will take care of both issues at once. Thanks! -- Florian