Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp685999imb; Fri, 1 Mar 2019 11:10:13 -0800 (PST) X-Google-Smtp-Source: APXvYqyR1yCRyzyB5JclhawFRBLI8TKDXAEVYcrjIyCKLF3vd8Xv1BrmxfRVy6JgQEYRnSvf8hAG X-Received: by 2002:a17:902:7d89:: with SMTP id a9mr6921737plm.33.1551467413861; Fri, 01 Mar 2019 11:10:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551467413; cv=none; d=google.com; s=arc-20160816; b=oCeYulvFww/d8cD9Fq/HSvlVfdSxJn0U8RgeQJYspGr+sD0kNmZrgzCWCMjW0CP0hq S4w1/U2cfJTvz85jEbYmLj1ZBEMTf4Z84w+WEB0GDsu4PeSDvGuUnFbmcG61e1C0po0P 7PzkyUIBW2yU1KD42MKOLPBr+WXAJlvg9r1WMlYXOI6NLWM6qsaIIq96mIc+BrikCUep EwhX9vYYxXo1dmCGat54p32x54eu7lRJOZjUs/xcCd1FHKontcxuju1ohFCQpTpVsh/P Tr7T0mpdAATZXQj/nrEWPrv4/J4xyyQR8WO5sOYvnGRk2Wi3cPf6hQ4TP445D8cD3yBz XhjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=KPtiIX2LSNx2zYYkLcC+6mePUUHTAz4vgefDk2h4ipc=; b=UgmZhB4MQS3e7PtXWoNGmYk71DdKEudeDuQk/DjBE3hADPlvhfVNjdbdWV93TYGDJR AW1M/9WqawjWlBOs12zf/LVfw9QHsjM94KsFqv9AMiQdX5a5lAHzp3GjnHc398P0eBub tsTiTHzQiQ3LKg7KY4zaVXU7yOGMgGMmGCatKGD9V2BpdRSwsWSfnC8fWQ40gGWyFdvZ e7IOxEfzHvvAWLMgX8xruPMxeqDc0kEvdRtkpPD6xHc7zgEfnDVlKFoc4EQc4gHTNkox I9LjweTT8J/V5aPQoLrXY5uyrZ4Tq6UiS4zlcDYzHdlzgSOdw/7W9Fwu5luzCJYoPfle tR8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9si21010344pgi.76.2019.03.01.11.09.58; Fri, 01 Mar 2019 11:10:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388799AbfCARiS convert rfc822-to-8bit (ORCPT + 99 others); Fri, 1 Mar 2019 12:38:18 -0500 Received: from vegas.theobroma-systems.com ([144.76.126.164]:58847 "EHLO mail.theobroma-systems.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726835AbfCARiS (ORCPT ); Fri, 1 Mar 2019 12:38:18 -0500 Received: from ip092042140082.rev.nessus.at ([92.42.140.82]:56474 helo=[10.2.146.249]) by mail.theobroma-systems.com with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gzm6q-0006e6-5e; Fri, 01 Mar 2019 18:38:08 +0100 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [PATCH 1/3] phy: rockchip-emmc: Allow to set drive impedance via DTS. From: =?utf-8?Q?Christoph_M=C3=BCllner?= In-Reply-To: <1347b956-5682-1f86-b38c-7768bb9ffd23@arm.com> Date: Fri, 1 Mar 2019 18:38:07 +0100 Cc: robh+dt@kernel.org, mark.rutland@arm.com, heiko@sntech.de, shawn.lin@rock-chips.com, devicetree@vger.kernel.org, Matthias Brugger , linux-kernel@vger.kernel.org, Emil Renner Berthing , Viresh Kumar , Randy Li , Douglas Anderson , Vicente Bergas , Kishon Vijay Abraham I , linux-rockchip@lists.infradead.org, Tony Xie , Klaus Goger , Enric Balletbo i Serra , Philipp Tomsich , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 8BIT Message-Id: <0DE1481B-7F61-4D85-9593-07E9680AC0EC@theobroma-systems.com> References: <20190301153348.29870-1-christoph.muellner@theobroma-systems.com> <1347b956-5682-1f86-b38c-7768bb9ffd23@arm.com> To: Robin Murphy X-Mailer: Apple Mail (2.3445.9.1) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robin, > On 01.03.2019, at 17:51, Robin Murphy wrote: > > On 01/03/2019 15:33, Christoph Muellner wrote: >> The rockchip-emmc PHY can be configured with different >> drive impedance values. Currenlty a value of 50 Ohm is >> hard coded into the driver. >> This patch introduces the DTS property 'drive-impedance-ohm' >> for the rockchip-emmc phy node, which uses the value from the DTS >> to setup the drive impedance accordingly. >> Signed-off-by: Christoph Muellner >> Signed-off-by: Philipp Tomsich >> --- >> drivers/phy/rockchip/phy-rockchip-emmc.c | 38 ++++++++++++++++++++++++++++++-- >> 1 file changed, 36 insertions(+), 2 deletions(-) >> diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c >> index 19bf84f0bc67..5413fa73dd45 100644 >> --- a/drivers/phy/rockchip/phy-rockchip-emmc.c >> +++ b/drivers/phy/rockchip/phy-rockchip-emmc.c >> @@ -87,6 +87,7 @@ struct rockchip_emmc_phy { >> unsigned int reg_offset; >> struct regmap *reg_base; >> struct clk *emmcclk; >> + unsigned int drive_impedance; >> }; >> static int rockchip_emmc_phy_power(struct phy *phy, bool on_off) >> @@ -281,10 +282,10 @@ static int rockchip_emmc_phy_power_on(struct phy *phy) >> { >> struct rockchip_emmc_phy *rk_phy = phy_get_drvdata(phy); >> - /* Drive impedance: 50 Ohm */ >> + /* Drive impedance: from DTS */ >> regmap_write(rk_phy->reg_base, >> rk_phy->reg_offset + GRF_EMMCPHY_CON6, >> - HIWORD_UPDATE(PHYCTRL_DR_50OHM, >> + HIWORD_UPDATE(rk_phy->drive_impedance, >> PHYCTRL_DR_MASK, >> PHYCTRL_DR_SHIFT)); >> @@ -314,6 +315,28 @@ static const struct phy_ops ops = { >> .owner = THIS_MODULE, >> }; >> +static u32 convert_drive_impedance_ohm(struct platform_device *pdev, u32 dr_ohm) >> +{ >> + switch (dr_ohm) { >> + case 100: >> + return PHYCTRL_DR_100OHM; >> + case 66: >> + return PHYCTRL_DR_66OHM; >> + case 50: >> + return PHYCTRL_DR_50OHM; >> + case 40: >> + return PHYCTRL_DR_40OHM; >> + case 33: >> + return PHYCTRL_DR_33OHM; >> + } >> + >> + dev_warn(&pdev->dev, >> + "Invalid value %u for drive-impedance-ohm. " >> + "Falling back to 50 Ohm.\n", >> + dr_ohm); >> + return PHYCTRL_DR_50OHM; >> +} >> + >> static int rockchip_emmc_phy_probe(struct platform_device *pdev) >> { >> struct device *dev = &pdev->dev; >> @@ -322,6 +345,7 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev) >> struct phy_provider *phy_provider; >> struct regmap *grf; >> unsigned int reg_offset; >> + u32 val; >> if (!dev->parent || !dev->parent->of_node) >> return -ENODEV; >> @@ -345,6 +369,16 @@ static int rockchip_emmc_phy_probe(struct platform_device *pdev) >> rk_phy->reg_offset = reg_offset; >> rk_phy->reg_base = grf; >> + if (of_property_read_u32(dev->of_node, "drive-impedance-ohm", &val)) { >> + dev_info(dev, >> + "Missing drive-impedance-ohm property in node %s " >> + "Falling back to 50 Ohm.\n", >> + dev->of_node->name); > > I think we're aiming to use %pOF for node names now, but here it looks redundant anyway - dev_info() will already show the device name, which for an of_platform device is the same thing. > >> + rk_phy->drive_impedance = PHYCTRL_DR_50OHM; >> + } else { >> + rk_phy->drive_impedance = convert_drive_impedance_ohm(pdev, val); >> + } > > FWIW, if you initialise val to the default (i.e. 50) then you could get rid of the "else" case and just do the conversion unconditionally. That's a fairly common idiom for reading optional properties. Ack. For v2 I've removed the else case (not defined value). Thanks, Christoph > > Robin. > >> + >> generic_phy = devm_phy_create(dev, dev->of_node, &ops); >> if (IS_ERR(generic_phy)) { >> dev_err(dev, "failed to create PHY\n");