Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp825546imb; Fri, 1 Mar 2019 15:28:10 -0800 (PST) X-Google-Smtp-Source: APXvYqzBoeoGk5x/iyPtsxbV52FWcqkwxT0uHdmzXBZhGK06HcFahHw9xlkdqfJMbdxVuq1/w8F7 X-Received: by 2002:a63:6e8d:: with SMTP id j135mr7411342pgc.160.1551482890161; Fri, 01 Mar 2019 15:28:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551482890; cv=none; d=google.com; s=arc-20160816; b=Dyvg0ua99UIlElRQmK/647+Z+oNfo0BnXKDHQwT6cw27rCiQFhSPNldF3q4gAEEfrd 3iY+b+UeU7d/VOaE5uVqWvDR82pd38PeD9lpDgbcP6ktFxwuQdKtpzRbQSSN5V/XxQrF 3EJuP9o2ZkSVDZ8oaZVqX0FUXRw3ywGgOPWPDVTPCXB/uZR700incrtvYiyGCp5E41WS ctwuI5Z4w0+bTLf5uw1Unm+lfGX/mOvhHUI0aUqXxTInc3EqQdO5q6Fq+7PweZIuERhH GDYU8E/fPtbAtuOLlODD8AH3e0xk+yg+cTOpgXA4ajJiMXfPmsaaxC8Ubw1BvIMwpwwx kPMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=CxMSec5AAtG8cchuHxOJ8OypYLZfqDq4LNUDOOaJjUA=; b=mQyaoylOWm3h92W2IMeQ2cqYgFktdyEUlOupLpoXs7jLeuR8v0pnFp1sNdh8j7ZYT0 mXMdX+JDhsT5DP3mB9umUVquAo945CPZ0xP27Tht2qO3fqOE52AliqhcpB2nYwOqqVhQ fawSjntJhtUFKXhS2cXS/guSX4re+9IBFxMH7OTech/Z1qj2TG6ZD02LX/g4kw5jDcby FzJpOjNSLhOzgLbI5EwMQnI8JEnLSmFdEiVWRuDeaPWtLuH5u3HCsESmpzWgPAW5bM8A TfvIxSKAlCfGaN6kSm2X9W5sD44PHz2qU2mRCCqbboRrWLwIkouIu2nxxOsq4PuTsDR4 fCPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X9uoAXRf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g19si21914851pgg.235.2019.03.01.15.27.54; Fri, 01 Mar 2019 15:28:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X9uoAXRf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbfCAX11 (ORCPT + 99 others); Fri, 1 Mar 2019 18:27:27 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:35808 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725958AbfCAX11 (ORCPT ); Fri, 1 Mar 2019 18:27:27 -0500 Received: by mail-pg1-f194.google.com with SMTP id e17so10093714pgd.2; Fri, 01 Mar 2019 15:27:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=CxMSec5AAtG8cchuHxOJ8OypYLZfqDq4LNUDOOaJjUA=; b=X9uoAXRfwenhnt8LTzzikS/SKYVE0drhKmZ7pka/+x2jl8s1SM2JZtrLEpdlpgJScn Sx3Rq2uDsJY3NyyMcQcjDicPPFsknNYothU0A8b+wasMh/acgO/mn20MYLcifvaXrG90 v8/VQ/hJd9VwU8o54i8E51mBXyYRl3DQB11H+GmDc0hiKuBYpqTUQECLqj5ns+XiwhPV Pxl+yavAl/BRelnaHBS1cwzHkwvU0sDCfjTdhaHinGN2XP21IXULGr4Y57gmw2+DVo2B gaWX63qa9rL77FhoAlYOjKdFvdBp5pq38vAeNsG/rJThg1Poe+6ilTl7ugi8DVwG4lMl /lbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CxMSec5AAtG8cchuHxOJ8OypYLZfqDq4LNUDOOaJjUA=; b=hWI7GFVglsj2fLqdtcTotjseb3ASLGBDVrXdQboOgjfVgnftpjCOn/fsooeQkKCzvU /vQGdbip7cVMSYDOgQbdevVuWXTnP16JVBu3Z7U6sWK89z1IeUZXgFf2DTrSFxfuZaBn pQLvOnZr6ejbXy//LP++oMaNRH0lRuvn4rYvwVL+TiIWdjUBHAYgAVugGFwko6hs4FGq py2Iq2qSYg72Gl7yd7vigLDen2fa9M7hRhdbp+ESfCqyk2wYvyr5o8qWLEu807GrswhI pMLHVae9+VjsONPAuNUA4aSp+I2K/R1LURSa1E7RLoWllO3+lntXEAOIWhh0Fv4l54mg KtQQ== X-Gm-Message-State: AHQUAuaTmH73ONE0e8pcrsh8fjAgR6Gb/JK6adxP7CPfhneupFQgXAB4 WnUFmzXiZfKRzFBNtrYNXaiyLC0e X-Received: by 2002:a62:bd09:: with SMTP id a9mr8119475pff.61.1551482845824; Fri, 01 Mar 2019 15:27:25 -0800 (PST) Received: from majic.sklembedded.com (c-73-202-231-77.hsd1.ca.comcast.net. [73.202.231.77]) by smtp.googlemail.com with ESMTPSA id j197sm38618108pgc.76.2019.03.01.15.27.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 15:27:24 -0800 (PST) From: Steve Longerbeam To: linux-media@vger.kernel.org Cc: Tim Harvey , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] media: imx: vdic: Fix wrong CSI group ID Date: Fri, 1 Mar 2019 15:27:17 -0800 Message-Id: <20190301232717.4125-1-slongerbeam@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The i.MX7 capture support forgot to change the group ID for the CSI to the IPU CSI in VDIC sub-device, it was left at the i.MX7 CSI group ID. Fixes: 67673ed55084 ("media: staging/imx: rearrange group id to take in account IPU") Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-vdic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-vdic.c b/drivers/staging/media/imx/imx-media-vdic.c index 2808662e2597..d36f6936c365 100644 --- a/drivers/staging/media/imx/imx-media-vdic.c +++ b/drivers/staging/media/imx/imx-media-vdic.c @@ -744,7 +744,7 @@ static int vdic_link_setup(struct media_entity *entity, remote_sd = media_entity_to_v4l2_subdev(remote->entity); /* direct pad must connect to a CSI */ - if (!(remote_sd->grp_id & IMX_MEDIA_GRP_ID_CSI) || + if (!(remote_sd->grp_id & IMX_MEDIA_GRP_ID_IPU_CSI) || remote->index != CSI_SRC_PAD_DIRECT) { ret = -EINVAL; goto out; -- 2.17.1