Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp872908imb; Fri, 1 Mar 2019 17:19:52 -0800 (PST) X-Google-Smtp-Source: APXvYqyF0UlgHqQHmlnCVIsLke11S/v2loCtNC7hq4drhMFUQzwxHvH5LQGKnIv1jYt4DYzKse0N X-Received: by 2002:a17:902:7682:: with SMTP id m2mr8649800pll.311.1551489592183; Fri, 01 Mar 2019 17:19:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551489592; cv=none; d=google.com; s=arc-20160816; b=LuLMR5oONe57ks3QcozR6nMal//h7N8lYfVDk+7u2RFpE2M1vMTA0lYU2yS8EZlaoJ g+BsXT8fSrtvU+/9ymi9+IBiDWPi0HKpbeAKbPzCXasv35aArqJWRjLtqQVsygUDmeNa 4Vvd866mRTMHTdLRKivDX47X/pUYAURjYg00LDvaO53U9Bs/pVwEULDFi444n7jwXIq8 DPaVVziuGasY06WSIctus5e7/EF83eQiXQva8hv9GQfhnjTm2kqXRo1N5W+m6dLoW0ci dNSlIwl6qPknooIgGMvrDEOIWRjJwHgqynD0H5rabevEmv2g135nDf3eyx6Y6h+e/8N6 gzVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=2uwGWGzgkLmBXCkfFi0H5fk+Xl+X7t7tZITSE2ZuzuQ=; b=CfX6lkTS9Dq63MbcvKnK7dFhWWTQtZCN5jSIgcWg9gNTHVqCgNHEHvxFw+teBMO4WX +czpYOx12/vR0ffTOwwNap70ZbAzBrPHh5yO/587yFT6MSnX6++4/B8+zXcntKxJ11a6 UP7oq498ZLLDxgAuDFk7DFR6ScjGNpSOi+qvslFboqPe7jzfpvwX/n5GtQBq7GvAlsid qJbj6pjNzH1n3fPZdNbLmW4wigXqNyFWNrjdPZ8mg/zEM0Nd8dZmlw8DcOx7QHOHRjFu VivPeyYTMIWwhNYQzHRpBVVIsCCiEMmd0YJ3+5UR2CxfkMTW1dM0KCBsHepGkvnxwXB7 ep7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i69si11619068pge.103.2019.03.01.17.19.36; Fri, 01 Mar 2019 17:19:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727755AbfCBBSF (ORCPT + 99 others); Fri, 1 Mar 2019 20:18:05 -0500 Received: from mx2.suse.de ([195.135.220.15]:47538 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726007AbfCBBSD (ORCPT ); Fri, 1 Mar 2019 20:18:03 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 56C59AD3E; Sat, 2 Mar 2019 01:18:01 +0000 (UTC) From: Tony Jones To: linux-kernel@vger.kernel.org Cc: acme@kernel.org, linux-perf-users@vger.kernel.org, Tony Jones , Seeteena Thoufeek , Arnaldo Carvalho de Melo Subject: [PATCH v2 2/7] perf script python: add Python3 support to futex-contention.py Date: Fri, 1 Mar 2019 17:18:58 -0800 Message-Id: <20190302011903.2416-3-tonyj@suse.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190302011903.2416-1-tonyj@suse.de> References: <20190302011903.2416-1-tonyj@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Support both Python2 and Python3 in the futex-contention.py script There may be differences in the ordering of output lines due to differences in dictionary ordering etc. However the format within lines should be unchanged. The use of 'from __future__' implies the minimum supported Python2 version is now v2.6 Signed-off-by: Tony Jones Signed-off-by: Seeteena Thoufeek Cc: Arnaldo Carvalho de Melo --- tools/perf/scripts/python/futex-contention.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/perf/scripts/python/futex-contention.py b/tools/perf/scripts/python/futex-contention.py index f221c62e0a10..0c4841acf75d 100644 --- a/tools/perf/scripts/python/futex-contention.py +++ b/tools/perf/scripts/python/futex-contention.py @@ -10,6 +10,8 @@ # # Measures futex contention +from __future__ import print_function + import os, sys sys.path.append(os.environ['PERF_EXEC_PATH'] + '/scripts/python/Perf-Trace-Util/lib/Perf/Trace') from Util import * @@ -33,18 +35,18 @@ def syscalls__sys_enter_futex(event, ctxt, cpu, s, ns, tid, comm, callchain, def syscalls__sys_exit_futex(event, ctxt, cpu, s, ns, tid, comm, callchain, nr, ret): - if thread_blocktime.has_key(tid): + if tid in thread_blocktime: elapsed = nsecs(s, ns) - thread_blocktime[tid] add_stats(lock_waits, (tid, thread_thislock[tid]), elapsed) del thread_blocktime[tid] del thread_thislock[tid] def trace_begin(): - print "Press control+C to stop and show the summary" + print("Press control+C to stop and show the summary") def trace_end(): for (tid, lock) in lock_waits: min, max, avg, count = lock_waits[tid, lock] - print "%s[%d] lock %x contended %d times, %d avg ns" % \ - (process_names[tid], tid, lock, count, avg) + print("%s[%d] lock %x contended %d times, %d avg ns" % + (process_names[tid], tid, lock, count, avg)) -- 2.16.4