Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 2 Mar 2019 10:10:47 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Andy Lutomirski <luto@kernel.org>
Cc:     Steve Muckle <smuckle@google.com>, Shuah Khan <shuah@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH] selftests: x86: add version check in test_syscall_vdso
Message-ID: <20190302091047.GA14963@kroah.com>
References: <20190301001806.154271-1-smuckle@google.com>
 <CALCETrUcH9R62gDdiG-EGTfSt2kQktv-0+bYmPcLn4PWNMrHSQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALCETrUcH9R62gDdiG-EGTfSt2kQktv-0+bYmPcLn4PWNMrHSQ@mail.gmail.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 01, 2019 at 11:59:24AM -0800, Andy Lutomirski wrote:
> > On Feb 28, 2019, at 4:18 PM, Steve Muckle <smuckle@google.com> wrote:
> >
> > Since 4.17 registers r8-r11 are not clobbered/zeroed by a 64-bit kernel
> > handling a 32-bit syscall and this behavior is enforced by the
> > test_syscall_vdso testcase. See commit 8bb2610bc496
> > ("x86/entry/64/compat: Preserve r8-r11 in int $0x80").
> >
> > Permit the old behavior in the testcase for kernels prior to 4.17.
> 
> NAK.  If you want an old buggy kernel to pass a test, please either
> patch the kernel or run an old test.

Yeah, this isn't ok, especially as you might have 4.14 or 4.9 kernels
that can pass the test if the needed patches were backported.  Checking
kernel version numbers should never be used for anything.

greg k-h