Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp1325149imb; Sat, 2 Mar 2019 10:48:19 -0800 (PST) X-Google-Smtp-Source: APXvYqw+Fu1EQ1W7E4O6nsQq90Ic9aS1BbuI1Mj2IhMnfEP5rRUDyus86ZzKiF7jHSyk40k75iAn X-Received: by 2002:a17:902:9306:: with SMTP id bc6mr11685440plb.59.1551552499558; Sat, 02 Mar 2019 10:48:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551552499; cv=none; d=google.com; s=arc-20160816; b=w5tqO+s+8h074krmnzEiR03mkMr7yOq3VtE1pitS5ECrKVYDe+xIzp4OCjf6x+suqq zhNvWqbLIgvqckNOBBbwFUExXjj+BIFJwQoLPA3v11QDZp/BL/LSrT4qRm5tiM5lRA+H eWPJqPj8FE9nWB8/lWHfND+Q7pUDqjFItEkTuRaAER0grJq6pQj+LBjcztiNGnucYze9 tK/Ck4zhh+cYltxzpDOE49aI1b+AQKlo7aGsztJs+BmVIXKXhPEWR17PzCZ0M2T0b1Xt j8QpPRdjS70X62psJjo/nK3dU2lyaLDNEbMXMw+k9wp79TplSaf3nxQqppC7tDi2X/3Q FhhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tx4ASGBAzLGHsjmHKiJQSkY9E3fWxtKwk1dKqdKBjR8=; b=IP/Ll+Vc3wnySB4qAJBku9cPhn6pZ7SAduOUBT5vdK9qd6Ouml2XiYHe2kgROkHf/T SkzPY6+Sjmlj+M5rnRCupYe+AvYuwp/4pOVATrMHOvQHzKVWihgLdcUqRxXK5AzcVoek 3WUc4Myfh63FfPmWwdMv18tYd8elpVAyNoMmApRyQAUT8QLIZJtuRBEw0Vh1CFtcbxBH iOsWu3rQi5iadcODRpbanrLQVs0qFFu2iiZRj7EQwBlX7fbnFnPSa4KppGq/yY+VA1Hv 0F2r43FdYOxFv/+CHEG6ZRKhsBNlrckl19/ZkagOHxNEzZoxjhSFzMlc9zJdkT3ZWpyC hOxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=CUzTz9l1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5si1093034pgw.377.2019.03.02.10.48.03; Sat, 02 Mar 2019 10:48:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=CUzTz9l1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbfCBSq2 (ORCPT + 99 others); Sat, 2 Mar 2019 13:46:28 -0500 Received: from merlin.infradead.org ([205.233.59.134]:36240 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbfCBSq2 (ORCPT ); Sat, 2 Mar 2019 13:46:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tx4ASGBAzLGHsjmHKiJQSkY9E3fWxtKwk1dKqdKBjR8=; b=CUzTz9l1sHNMNJg65FqQcW45S jQAFFCxjQF9ThgJz3A2Qvr2QT45McJuM8YIR0vQeFzNmS/wR11nfAumCVEAHUM4t3OsmTzkCqHF/P gtGPY1sPXpEnJQsu4XUwGvBLkiIQv1FN/rnY92a+uZywkBZ+82w0O+PE5gRmwxKLrIYMJP06yJGia +4CiKQjyBin8njbFCmMveZcadT33ew7N3UPuy7P0Qwd7SZJERQIo4DdMli0v+Jy+rEv0yrX4DkVOW E61kXZopbu9X7CIGf/f0f6RsC9sXhFhwVCjLMC5lIrITnNhlX0nwtgN5Fyvi2kUd52lbXvuSAzp/b njtINShxQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h09do-0001Yd-RN; Sat, 02 Mar 2019 18:45:45 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 5ED0E984351; Sat, 2 Mar 2019 19:45:44 +0100 (CET) Date: Sat, 2 Mar 2019 19:45:44 +0100 From: Peter Zijlstra To: Jan Stancek Cc: linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org, riel@surriel.com, mhocko@suse.com, ying.huang@intel.com, jrdr.linux@gmail.com, jglisse@redhat.com, aneesh.kumar@linux.ibm.com, david@redhat.com, aarcange@redhat.com, raquini@redhat.com, rientjes@google.com, kirill@shutemov.name, mgorman@techsingularity.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/memory.c: do_fault: avoid usage of stale vm_area_struct Message-ID: <20190302184544.GM14054@worktop.programming.kicks-ass.net> References: <20190302171043.GP11592@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 02, 2019 at 07:19:39PM +0100, Jan Stancek wrote: > static vm_fault_t do_fault(struct vm_fault *vmf) > { > struct vm_area_struct *vma = vmf->vma; > + struct mm_struct *vm_mm = READ_ONCE(vma->vm_mm); Would this not need a corresponding WRITE_ONCE() in vma_init() ?