Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp1347046imb; Sat, 2 Mar 2019 11:40:36 -0800 (PST) X-Google-Smtp-Source: APXvYqxVWo2Po3kFtFOIG3+cwe1NuF7QUll9wkjYRVHGIHEOkz/+HJwEp4IxFqC23yUJ0+ALFOnl X-Received: by 2002:a65:4806:: with SMTP id h6mr11127002pgs.408.1551555636417; Sat, 02 Mar 2019 11:40:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551555636; cv=none; d=google.com; s=arc-20160816; b=Nq7vztfRhIyHHuPHVaSzkAJ7nITv3Rdwz7UYFOovSL/RB/YRjV5dWPCH7+azkGsa6H lD+i16C5gPRFVOXFqKa0Y6Wl6PLyy7lxk2KLOE2YjwtzCL/WwjuDYNpxao9GyINAcasF MzVtYeHSB1WboIUeGuC6oSxiGu5I3LBFGfp2v3xh9zSyZ/r1uIgROFHnCpbkhES8+01l QT1i/fRA8r0+PvIq1cVVmlcjbTzQFnleafTLuTC4E06O2XTRRRcp7csrk6O7RHJ2kemN /jfEZcSAf6zS8WOSxOarFeVE3z5Jz1wbgFIyRDsOL3+qqSxWFF3a/9mybnKtnLoG3Fju uvNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date; bh=8uhr5VjJNHr4x5fb99Cc2klSRgzDVLmircOscpDf0/A=; b=NJ5WvGNBqfT7JBg4pa3iFIt2eFwLl7LKj/30q9VnwnzyUn1zey0Q/SYudYL+06QFhB COvXz6qVzc80uKcWS/XtVfh1cYXuBrgFfs04pocVp+fKZ4IkwuCqJHl725hou21hdkGS Gbmtk4++8jK83g9UtxrwgCwVPDEqhdcdVAgx6RQTD/nvvOq0xK3+wDm8KS84O42DXWgv 6vVkuIwXMDNwggUTVrFDzABugy3UaX2lzDTU5zTncnZfwPnE7RBaluIchZ4HH6DhlOcc F0OnxQlgktdC6xrwhM4oK1R3j1/DNjAZ9Aa+PuxRnXub+ojLo293OoVEba/S07TJ2EQU R0gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12si1196461pgs.427.2019.03.02.11.40.07; Sat, 02 Mar 2019 11:40:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726681AbfCBTjh (ORCPT + 99 others); Sat, 2 Mar 2019 14:39:37 -0500 Received: from gateway31.websitewelcome.com ([192.185.143.33]:26022 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726529AbfCBTjh (ORCPT ); Sat, 2 Mar 2019 14:39:37 -0500 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 078DC5A21 for ; Sat, 2 Mar 2019 13:39:36 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id 0ATvhmyXfYTGM0ATvh3EaV; Sat, 02 Mar 2019 13:39:36 -0600 X-Authority-Reason: nr=8 Received: from [189.250.88.58] (port=49436 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.91) (envelope-from ) id 1h0ATv-003ZWz-54; Sat, 02 Mar 2019 13:39:35 -0600 Date: Sat, 2 Mar 2019 13:39:33 -0600 From: "Gustavo A. R. Silva" To: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eli Britstein Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH][next] net/mlx5e: Remove redundant assignment Message-ID: <20190302193933.GA13467@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.88.58 X-Source-L: No X-Exim-ID: 1h0ATv-003ZWz-54 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [189.250.88.58]:49436 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 7 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove redundant assignment to tun_entropy->enabled. Addesses-Coverity-ID: 1477328 ("Unused value") Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c index 40f4a19b1ce1..be69c1d7941a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c @@ -80,10 +80,8 @@ void mlx5_init_port_tun_entropy(struct mlx5_tun_entropy *tun_entropy, mlx5_query_port_tun_entropy(mdev, &entropy_flags); tun_entropy->num_enabling_entries = 0; tun_entropy->num_disabling_entries = 0; - tun_entropy->enabled = entropy_flags.calc_enabled; - tun_entropy->enabled = - (entropy_flags.calc_supported) ? - entropy_flags.calc_enabled : true; + tun_entropy->enabled = entropy_flags.calc_supported ? + entropy_flags.calc_enabled : true; } static int mlx5_set_entropy(struct mlx5_tun_entropy *tun_entropy, -- 2.21.0