Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp1809784imb; Sun, 3 Mar 2019 07:23:11 -0800 (PST) X-Google-Smtp-Source: APXvYqzRJ94QfmcjZdLSM8ccxd+n7RP3wtjW7A7l9eG+zXUUBMq8tDF9p4oG8+FdUktwLNm5NDX+ X-Received: by 2002:a63:4509:: with SMTP id s9mr14119109pga.420.1551626591518; Sun, 03 Mar 2019 07:23:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551626591; cv=none; d=google.com; s=arc-20160816; b=jL2HX5JJXIQtUnKZiuqn7FPayV/XkmNdsIBJ2Uj9b8MYK7TysAmqBu//Yvre29+bIC UeKlPyKWgv8jpT6QHmieUZH3nYrOFzCRHrFKKsClT7LOgQVc5PSJ67QGyGKD+kR3nmT+ RsubJdyERkIoNYwfAInaOMDWfylPZQG/zQ2jHiMm1tGYZvCJPm2lpU9nixB9CVXEG50X xWkMZo8fntqIbQtJsR5xvflvSEeTrpKjnV+BfeIMSnCtIOPjViX4eymZxZK00ZF2u3p4 mD5PKvsI48UT+3c/GsAnRveCszS9e9jTx/QKtx5zh9Yn1J4kg/caIjF3eLNZQtwO/cCE T3uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1AX2903etxyO98mlyoRn3DtofO5YytO7EUrBm0kx2Pc=; b=ORGf6LxFotS/dAsu/uIH7q6k6+l0GevVwZf6NujTh1+mF7eORlgz2t/+uvOLqNzgXd /WiaEtc1Ur3ulx8ye4JOz9btNlCDUUwAvyblp6uIHg/aAGyraq30li5R3yv8C02ipUNq B4uAwacRrvciJ10FYH5ZEg/g8SVnQiJ9kB1Wl9DNjy9fEBHEYbHTUyEXBIz4QtqvO+fh 1f+9uqy01xNlkFPoUQliJm5dqm66vAsT9EHurEwTTHmNMr3go/7AFJQyI35COtpDJitY 3TsuLRNABuYCg9nnjFa65YxMxp9DuoRoJwL3t8V7NAvD9MKZBCiW819gN5fa6SwIwGIA LgIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LuXSb6M1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 23si2970233pgc.220.2019.03.03.07.22.56; Sun, 03 Mar 2019 07:23:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LuXSb6M1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726414AbfCCPWY (ORCPT + 99 others); Sun, 3 Mar 2019 10:22:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:34470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726331AbfCCPWY (ORCPT ); Sun, 3 Mar 2019 10:22:24 -0500 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F8CC20836; Sun, 3 Mar 2019 15:22:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551626543; bh=cK/Ztr+6g037EKehlRtErEgNYsRIX2/hzzmcuemWVq4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LuXSb6M1OXVF1xpECnS8eXX8w0NbZ1u0KlqXIG5lzA9REILIsV4ZgCz+EVTXAJ442 Fn582ENt1BGNEvyBUfYtn5UTauwfoiNGtqWRwn6cnu+xJf7tDo8RgX9QF+DpCGKGcd axoySEtQhGAu/NNNgjDtzas9dONF+dEtA5MfH6sA= Date: Sun, 3 Mar 2019 15:22:15 +0000 From: Jonathan Cameron To: "H. Nikolaus Schaller" Cc: Linus Walleij , Rob Herring , Mark Rutland , Andy Shevchenko , Charles Keepax , Song Qiang , Jean-Baptiste Maneyrol , Martin Kelly , Jonathan Marek , Brian Masney , Stephan Gerhold , letux-kernel@openphoenux.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/10] iio: gyro: itg3200: add mount matrix support Message-ID: <20190303152215.52b0504c@archlinux> In-Reply-To: References: X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Feb 2019 18:02:51 +0100 "H. Nikolaus Schaller" wrote: > This patch allows to read a mount-matrix device tree > property and report to user-space or in-kernel iio > clients. > > Signed-off-by: H. Nikolaus Schaller Applied. Thanks, Jonathan > --- > drivers/iio/gyro/itg3200_core.c | 20 ++++++++++++++++++++ > include/linux/iio/gyro/itg3200.h | 1 + > 2 files changed, 21 insertions(+) > > diff --git a/drivers/iio/gyro/itg3200_core.c b/drivers/iio/gyro/itg3200_core.c > index 7adecb562c81..203a6be33b70 100644 > --- a/drivers/iio/gyro/itg3200_core.c > +++ b/drivers/iio/gyro/itg3200_core.c > @@ -242,6 +242,20 @@ static int itg3200_initial_setup(struct iio_dev *indio_dev) > return ret; > } > > +static const struct iio_mount_matrix * > +itg3200_get_mount_matrix(const struct iio_dev *indio_dev, > + const struct iio_chan_spec *chan) > +{ > + struct itg3200 *data = iio_priv(indio_dev); > + > + return &data->orientation; > +} > + > +static const struct iio_chan_spec_ext_info itg3200_ext_info[] = { > + IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, itg3200_get_mount_matrix), > + { } > +}; > + > #define ITG3200_ST \ > { .sign = 's', .realbits = 16, .storagebits = 16, .endianness = IIO_BE } > > @@ -255,6 +269,7 @@ static int itg3200_initial_setup(struct iio_dev *indio_dev) > .address = ITG3200_REG_GYRO_ ## _mod ## OUT_H, \ > .scan_index = ITG3200_SCAN_GYRO_ ## _mod, \ > .scan_type = ITG3200_ST, \ > + .ext_info = itg3200_ext_info, \ > } > > static const struct iio_chan_spec itg3200_channels[] = { > @@ -297,6 +312,11 @@ static int itg3200_probe(struct i2c_client *client, > > st = iio_priv(indio_dev); > > + ret = iio_read_mount_matrix(&client->dev, "mount-matrix", > + &st->orientation); > + if (ret) > + return ret; > + > i2c_set_clientdata(client, indio_dev); > st->i2c = client; > > diff --git a/include/linux/iio/gyro/itg3200.h b/include/linux/iio/gyro/itg3200.h > index 2a820850f284..0a30fddccfb3 100644 > --- a/include/linux/iio/gyro/itg3200.h > +++ b/include/linux/iio/gyro/itg3200.h > @@ -104,6 +104,7 @@ > struct itg3200 { > struct i2c_client *i2c; > struct iio_trigger *trig; > + struct iio_mount_matrix orientation; > }; > > enum ITG3200_SCAN_INDEX {