Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp1857849imb; Sun, 3 Mar 2019 08:56:28 -0800 (PST) X-Google-Smtp-Source: APXvYqzujzfuZtp7B6AKYz2Vs3T4/n+z3dQ6lAIPmSSnpu+mHDuzWFz4/3B1EamCfv8BjdA1zvn6 X-Received: by 2002:a63:6c01:: with SMTP id h1mr14629642pgc.330.1551632188572; Sun, 03 Mar 2019 08:56:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551632188; cv=none; d=google.com; s=arc-20160816; b=dIlMnookx6BXzAG+9A80DuJvgtk/+5VySF4HKB1fFel5yJSi1bBA7NlzIH99LAK2qf 9eHqskOu20MF/M4w8qqKOL74QhbI9vWlmL0Px7Ik1Lo1WADJYwn/+qOKBl7hYzCJLqna J9AaQJyzSnFhk+gYKnHFC/J36TDIfnAV7yPc6YzZi1zXGEQxoE1guBBb/JwqkFCAfKzx Zvmp/boekKUV9nU/1SZ6ENWvT1hetkmaI4aBiwtjJJsbK3PVKwaIz1JJ+3EIvt4H4/8t eJyIbiUL6MqZYJJg/505w9E0oETj1Q45nYuSviT9cyTTy50dakSQJZz+/H734x7zTf6b 7d2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2yFPRejGqIJ9YHlKsLvUggyDY/DBT+zSYg3ZLyXBPQM=; b=KPamsWs6IHz1STlY2y5jSt8gmDXgrkVgDmMiLDA6ocMbT+4mRE019dXdwMGNU2IoJJ UT2hFpeo6tdYk7MHW8X0F06IX1p4osjWWdqBSB4m+DH3GRqU0x/lLLc80mvAscdBJ7GF UAcwwaJgaC/Bis4yKPMTzLZjEL4/OMcJGDmazbk3h6vJJ8QXoSrZspNWSM7xWdOXHSIA lFIH34YKkQ2OjhZ8GyAZCVtBPCO4rTiSAMyPQszWouqcH+79OnXWeO0bRZ38XM0Ls8KK csjGBJfsuRGvE1E1quDG6N4wEl/vTGG5s6n+FE2+M5gwKUNMVxfr7hRCq+kt20RCDGO7 yjXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tomli.me header.s=1490979754 header.b=NBHlragC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=tomli.me Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h124si3132405pgc.25.2019.03.03.08.56.13; Sun, 03 Mar 2019 08:56:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@tomli.me header.s=1490979754 header.b=NBHlragC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=tomli.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbfCCQzw (ORCPT + 99 others); Sun, 3 Mar 2019 11:55:52 -0500 Received: from tomli.me ([153.92.126.73]:42626 "EHLO tomli.me" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726474AbfCCQzv (ORCPT ); Sun, 3 Mar 2019 11:55:51 -0500 Received: from tomli.me (localhost [127.0.0.1]) by tomli.me (OpenSMTPD) with ESMTP id 377c99eb; Sun, 3 Mar 2019 16:55:49 +0000 (UTC) X-HELO: localhost.lan Authentication-Results: tomli.me; auth=pass (login) smtp.auth=tomli Received: from Unknown (HELO localhost.lan) (2402:f000:1:1501:200:5efe:3d30:3659) by tomli.me (qpsmtpd/0.95) with ESMTPSA (DHE-RSA-CHACHA20-POLY1305 encrypted); Sun, 03 Mar 2019 16:55:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tomli.me; h=from:to:cc:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=1490979754; bh=q4L6XezyUz8vykrzKVzwY31jWC0rgV5GxcNGUX2GJME=; b=NBHlragC8DCbaOLy17Fj/0DKG4d7NMBdBVZo6dygE0RnxBLTpaXZDiF7VO9qWkQCIcSbNrBWcMi/VIAUjW4p34jyNIWrKXu4pGJ2etVJC+HesEW9l0wpk5Wakj3yYCuYmxwjurKP0mkRv0TCyeQd8J+si2hGanVCO0rs1ZDStoreVy1eUYGNrkRXN41Foe6bu2b07R4TlIi87Kk8uXODn+DAe4onJfSonWzu3025qkFhb2zHl5sgizr5EOUdO8j17MuE6WevS4I4jl+mldP1kJ50+WkFzgkwSRbO1LyHzDSG/O1Q7OTyUlVNwr1foRIJgqvH6FfMk3sCLW0qKqqmyQ== From: Yifeng Li To: Jiri Kosina , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org Cc: Yifeng Li , Sudip Mukherjee , Teddy Wang , linux-kernel@vger.kernel.org Subject: [RESEND][PATCH 1/2] staging: sm750fb: trivial comment indention fix. Date: Mon, 4 Mar 2019 00:55:31 +0800 Message-Id: <20190303165532.23727-2-tomli@tomli.me> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190303165532.23727-1-tomli@tomli.me> References: <20190303165532.23727-1-tomli@tomli.me> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In function sm750_hw_copyarea() of sm750_accel.c, there are some comments in ASCII graphs, describing 4 possible scenarios of overlapping areas when copying an area. However, the graphs have broken indention. The entire SiliconMotion series video controllers, including SM501, SM712 and SM750 have similar 2D engines, yet, I have not seen a single version of it with ASCII graphs properly formatted... Fix the the misleading ASCII graphs. It would eliminate the confusions and improve code readability. Signed-off-by: Yifeng Li --- drivers/staging/sm750fb/sm750_accel.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index eed840b251da..dbcbbd1055da 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -155,26 +155,26 @@ unsigned int rop2) /* ROP value */ if (sBase == dBase && sPitch == dPitch) { /* Determine direction of operation */ if (sy < dy) { - /* +----------+ - * |S | - * | +----------+ - * | | | | - * | | | | - * +---|------+ | - * | D| - * +----------+ + /* +----------+ + * |S | + * | +----------+ + * | | | | + * | | | | + * +---|------+ | + * | D| + * +----------+ */ nDirection = BOTTOM_TO_TOP; } else if (sy > dy) { - /* +----------+ - * |D | - * | +----------+ - * | | | | - * | | | | - * +---|------+ | - * | S| - * +----------+ + /* +----------+ + * |D | + * | +----------+ + * | | | | + * | | | | + * +---|------+ | + * | S| + * +----------+ */ nDirection = TOP_TO_BOTTOM; -- 2.20.1