Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2189736imb; Sun, 3 Mar 2019 21:39:27 -0800 (PST) X-Google-Smtp-Source: APXvYqwA37lXDINQI1PUM2njQvpgaNt5bRBoqGLUX/0dg1B4XnzBz08px52LurUfCzQqJA8XgDn2 X-Received: by 2002:a63:6e88:: with SMTP id j130mr16827204pgc.67.1551677967026; Sun, 03 Mar 2019 21:39:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551677967; cv=none; d=google.com; s=arc-20160816; b=RrcaiD51RdchdtInLmc0uOSBm8ifuwIpT2phpv9GKK4FiwKTOILkOmga/mPADcxsXn n8gDtD8dFMdrw41tEblTIHgODV1OqT8m/oW/6LYwup5VF9sfHtQ2GTkhBikM3Ga8OD6A H/lrEQI0jWvd14ZmuVe4K0OxBdTRAlpa9XUpRH4iupD2ZNeGz2+tSHdKbyuDeyN+U+tt Vpj3lFg7sIFpD9WAlNa8quD/fIn9zTYWoCbA3zCLTlXKzvZjF36Mqs95vjQVr30ktb0F iLM+WsAhDNo0l/WfRSU/apO1PhJM51HgDK71AB/OgG1yd6CDHkLhNZHc9GJFFdKGcAD8 Hzkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IPYFuYLenoaZiq+Ybs9FrcHOH5CvprPypOZXl5Mjdnw=; b=OfZNO0W8V9rWF7t3TDTlFJjn7kbYhA+Yo77g6RNEMROBFs9J87WsfpwP0noAn6993e c5N1q944NY+1fdJTxLKkbDa6ZLp3tCIEJdqKI8V11rTREOC7iBWPCLcG63RF/N9YuWG3 dcvV9RRQmjx9p15EA9w44+1vyT4+1LYiINWR4hePIU/e2Dy1X0aQdvGy6wtSiBiRXgu6 iT/JLT6M0zyX9RIp4e3iPxc34qJ1RnYOp+ODr1qhQOu+CZXpz7IpdVXPOazYuwCT0vzS CPf9slivJ5ouBaG8obci1gI3NM8wvsGrPUG7guHx51+IDhnJ4pkQu02RnHCQFvqt7ViN Qi2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kHq1wItZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l2si4608266pfc.287.2019.03.03.21.39.10; Sun, 03 Mar 2019 21:39:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kHq1wItZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726080AbfCDFi3 (ORCPT + 99 others); Mon, 4 Mar 2019 00:38:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:36510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbfCDFi3 (ORCPT ); Mon, 4 Mar 2019 00:38:29 -0500 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7747620815; Mon, 4 Mar 2019 05:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551677908; bh=g7AHdyOzT/zu/ZiJT1tf4ulU/osU03BVGW6r8HW1WMU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kHq1wItZ2IcNUbI2+Dn4y51A2o+v5TX84QIIskJyEnT/EWfRNd4KLq7LI4TcVtDWI IsBAr0tJbLL7rb14rPi2pO6RgaznJpRt5qBaFX3makMfC09M8een7JdjM1ZIj8K2n5 2hv873k7oaLKvUfjhF1cRFQYINuVJgUqoKWKsRdk= Date: Mon, 4 Mar 2019 13:37:15 +0800 From: Shawn Guo To: Wen Yang Cc: liviu.dudau@arm.com, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kgene@kernel.org, krzk@kernel.org, linux-samsung-soc@vger.kernel.org, michal.simek@xilinx.com, afaerber@suse.de, manivannan.sadhasivam@linaro.org, dinguyen@kernel.org, heiko@sntech.de, linux-rockchip@lists.infradead.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linus.walleij@linaro.org, avifishman70@gmail.com, tmaimon77@gmail.com, venture@google.com, yuenn@google.com, brendanhiggins@google.com, openbmc@lists.ozlabs.org, xuwei5@hisilicon.com, maxime.ripard@bootlin.com, wens@csie.org, catalin.marinas@arm.com, will.deacon@arm.com, horms@verge.net.au, magnus.damm@gmail.com, linux-renesas-soc@vger.kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com, wang.yi59@zte.com.cn, Fabio Estevam , Lucas Stach Subject: Re: [PATCH 05/15] ARM: imx51: fix a leaked reference by addingmissing of_node_put Message-ID: <20190304053714.GZ26041@dragon> References: <1551430616-42014-1-git-send-email-wen.yang99@zte.com.cn> <1551430616-42014-5-git-send-email-wen.yang99@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551430616-42014-5-git-send-email-wen.yang99@zte.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 01, 2019 at 04:56:46PM +0800, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang Applied, thanks.