Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2212172imb; Sun, 3 Mar 2019 22:27:27 -0800 (PST) X-Google-Smtp-Source: APXvYqzK/v4qHjXxYzJLHGl7Yl68bVox4qZqTqKxZkDeXWJA/aTzzYQt4RBU/JoVSfu6TDg4t533 X-Received: by 2002:a63:f544:: with SMTP id e4mr17143437pgk.145.1551680847261; Sun, 03 Mar 2019 22:27:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551680847; cv=none; d=google.com; s=arc-20160816; b=T0NObkDKzYSAeuqS5r2pbHtgGwNjTV+atVBluua5MoSpDp7KOfme56sJQDgHTDJjGg u25YlXpTI7S+ajacBk4Yr5kgGW5XUSfERwHCbw3AZm8KJ6c0dzCP2PVk6+BnuLGeklGT nqszEl8RCm3U8bkJvHyFQ2stDnGKcpWOjkqQFJdwg0Mto1fqiduAQVpXdG5oroR/3s0h jR2hNdethQUWz6RQuW2pdzT3iT8JxmikFi3lQ8hzV3CIm9KEL/ADjgJAjocvKuSc3Zj2 jgvtiK9PWRcQqptK57LJmQkcJVTVyJbuZHw1MEh430loeaOhIXXTUtuo/kz9Bny1VOXa AkQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Vium3mBj9I6RjwBV0bGoveo24/PCh3NRnmBMTPtCG1Y=; b=gb1r/TjoEhVF0xecyhQa9gEogJdR0bQyN/4SQ+wrIQOgaqnf9k15EueLmH/9TioALN HIjJzeoi54YOUSid4e+MGjp8jM5nmCrX8rN9UN9OEGH8XG8XJ+SmmuBTWAq5k+OyVWpF XuzDqU6tYoe3D/7RFh2FCPDNRy9ZEtL8rGaIgBYnI7zGys34Z8cr+N5NWeCb+TmZ0KwX dvQNFCwtnhaJpiNOclQwpPGSfL1R1dAb56hriSdZLy2LI6+h5GAli3e5ZWSmI/uywYJh W2g84eiykR8pG0xDIEGBM3OSv4y+BvHCBftGGkAk5q+qXbmTpHpCb0MB4m1WQ6vQLIzZ sa7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vqi5SsYQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u17si4555610pgh.487.2019.03.03.22.27.11; Sun, 03 Mar 2019 22:27:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vqi5SsYQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726037AbfCDG0v (ORCPT + 99 others); Mon, 4 Mar 2019 01:26:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:38334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbfCDG0u (ORCPT ); Mon, 4 Mar 2019 01:26:50 -0500 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70EA920823; Mon, 4 Mar 2019 06:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551680810; bh=Vium3mBj9I6RjwBV0bGoveo24/PCh3NRnmBMTPtCG1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vqi5SsYQlw5tdJQPg+fn4vl8IUJ75qz1xOxlU/7b3lP/4EzVsFJjd8WCieTrp8NGR QCY68ASPhfpGH4UYFV0Ez/uZzV+IyoR8OS7ug00KpZJUt6ZSV3LegmXaacBfBzfR7T S12JZ8NbDyo5FFGP/MOoFtJPnLkMf40rxC/laJb0= Date: Mon, 4 Mar 2019 08:26:45 +0200 From: Leon Romanovsky To: Roi Dayan Cc: "Gustavo A. R. Silva" , Saeed Mahameed , "David S. Miller" , Eli Britstein , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH][next] net/mlx5e: Remove redundant assignment Message-ID: <20190304062645.GZ15253@mtr-leonro.mtl.com> References: <20190302193933.GA13467@embeddedor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9r3HF47jptiQlX4s" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --9r3HF47jptiQlX4s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Mar 03, 2019 at 03:20:57PM +0000, Roi Dayan wrote: > > > On 02/03/2019 21:39, Gustavo A. R. Silva wrote: > > Remove redundant assignment to tun_entropy->enabled. > > > > Addesses-Coverity-ID: 1477328 ("Unused value") > > Fixes: 97417f6182f8 ("net/mlx5e: Fix GRE key by controlling port tunnel entropy calculation") > > the commit doesn't fix any real issue but is more of a cleanup. > so I'm not sure if fixes line is relevant or not. > beside that looks ok. It doesn't matter if it is real issue or not, the code is wrong and should be fixed. This alone is enough to see the Fixes line. Thanks, Acked-by: Leon Romanovsky --9r3HF47jptiQlX4s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcfMUlAAoJEORje4g2clinGywP/0ZpFYeue+bt8fx34KHJ8tyF bpIcORNXSGq00bKlxkQzVcXWxUl8PsWDpYjfnGVX3dq1GypbNkRcqIW8hWxvfyYR YmCTEsFFts1CguikXedcKIfBKg8dHWu4FZi2qzbAvn4nzdx/fUUK/1mu/P+3S+Gx lDaChHQn83cR7Raik28S8ArJZLbSqebaZyYL+DkG6r1NE8to6EzTmdL/V6f9Z79W DjZNbjJQ7ktZ0iHkPcSDDuPJadgAk6dViSiE4oYT8ZLGFo1v9Wj4S4BJiAkPlU1I UAI+fGx4TpKYijDZqcNCIDyM2F0PlZqQmk/4Bb9bfgJP0ZE9kEumIq7oHydumgfl C71HWwNnGXCbOYuk9xO5QSIIemn8fiOnWbQceckHIK9e39aKfFjp0io+rQ/JvMRP 2gXHig1hZ+soFSKhVXP8uM9n0D83JMDMWR9drcO7w1hvSrXE5EhzmfQ0uEopaYpA H+4vSv6i8cnTNaYpSLF0aN6On+MzHXOwLs6eLRRtPqbSjJbA5Ul9GhQ/ZWq7w7u9 91wGT6PbwcfGQkP2RRATahTw5CjLSZ53r5FUS4VKmj+IlI4c0GaQUhnN7vKBDz8f +V/iaXJyeiDxNZK7EGSMK7aNC+l50AXfmA9oKgrQL+A4vBeUKBFoZeBYCtIiAWiV +gu47+oFj1mntPV+xdxK =aGGP -----END PGP SIGNATURE----- --9r3HF47jptiQlX4s--