Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] f2fs: fix to check inline_xattr_size boundary
 correctly
To:     Chao Yu <chao@kernel.org>, <jaegeuk@kernel.org>
CC:     <linux-f2fs-devel@lists.sourceforge.net>,
        <linux-kernel@vger.kernel.org>
References: <20190214160825.4973-1-chao@kernel.org>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <82ef0ff8-452c-1894-6776-41c70ad7654b@huawei.com>
Date:   Mon, 4 Mar 2019 14:39:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190214160825.4973-1-chao@kernel.org>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jaegeuk,

On 2019/2/15 0:08, Chao Yu wrote:
> ---
> v2:
> - fix lower bound check, inline xattr size should be larger than
> xattr_header's size at least.

...

> +		if (F2FS_OPTION(sbi).inline_xattr_size <
> +			sizeof(struct f2fs_xattr_header) / sizeof(__le32)

No sure we should set this low bound as above... now I guess original
non-zero check is enough.

How do you think of setting inline_xattr_size range as
(0, MAX_INLINE_XATTR_SIZE]?

Thanks,