Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2276229imb; Mon, 4 Mar 2019 00:30:35 -0800 (PST) X-Google-Smtp-Source: APXvYqwAk5XiLQ9VwfV1SeSe0+zH3XpvT3nDZHfJfjgdtAeiiTacunUSLpeQnRZXVBmje2ySXqdi X-Received: by 2002:a17:902:728f:: with SMTP id d15mr19303141pll.156.1551688235273; Mon, 04 Mar 2019 00:30:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551688235; cv=none; d=google.com; s=arc-20160816; b=xAMegA8mEaTqYNN/duivvFVAa99rJzLwMf604NJdoU08Fl5t0HKbMNgwyuPuJu17O3 ZXqinJjP83Lnqjb7bEsFQaoRUsXXz/Lc+rljXtVqBIJbCYTgS+7mUR9EfKnQHUHgni6R YlzUhuv+GvBT09OuVIsWS/38jyKoA/t+J3KGY9UxxqIPo07uw53E0/V7m+XJyHozeoNj im6yFN5VbS/QzNTemiOKsluvBNvPyTf5HBMmZ/pHcERYsQFTb5gjod4nvgK97wgdjwJy fx5OAeYV9Jf0NM6+dqAPi8WVXT5xSz+8m5we1A4amS4OCx8vrEn0D1ssTUTJhBU9lZdH Hd8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bs4sr+xf3xEUG0lUISCvKK0nV/UYsQlglGMKMPWHt0Y=; b=ACi/3+oh/Jxk32UkhEOfRCs3xzj588YuLjuTmd+CO/rhLWLEJAP15+j5frwTymsaI4 vk2QWoKh2EByp2a5Zy69hDBUusJ7+14hFTu7R70DdV/0TP5nUpf6UEzPDRpr2YnNcpTX cnLZVOOGaTYtB0oXMsjPnFYxzLUXURIyB7eNYG7uhDdEq4hFFlSBjJVb77nMO8H7wwoz w2Na5k8AulB78VRaJvYFKdmZwMTaPxugmAa+DcP68qA7DW/cw50jEdCBC5WAqoanBs5z aGtjn+PWLK7D6s0Guiwz+aMnAIF37PBEYJHcnGuWazlVfeDSLBnPP3MBfrbfJKJlH4zA /H2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NXz4aJRH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z15si4598439pgv.209.2019.03.04.00.30.19; Mon, 04 Mar 2019 00:30:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=NXz4aJRH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727579AbfCDI3g (ORCPT + 99 others); Mon, 4 Mar 2019 03:29:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:56328 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727577AbfCDI3e (ORCPT ); Mon, 4 Mar 2019 03:29:34 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0BAD20836; Mon, 4 Mar 2019 08:29:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551688173; bh=/sXOX+PrO+mfXJZ+Xzpb9kxnKmMO3ZH6paPQbd7UEvY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NXz4aJRHuxFp0mInGm6AthwfTcHMAyu/ZX4cCuemFpboMUqNg6dTqxb+8vxUibF/0 74VpRi47wUw/2poQmnwoKwvvh4+NyuA7oUzERsWxdc2WqnAda13KQDQl/w/VC1gfl6 pW+5diUL2DP/GyXsUBJ8XiT3qQJd7kp1qWSeg2VY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Matthias Kaehlcke , Sasha Levin Subject: [PATCH 4.19 40/78] tty: serial: qcom_geni_serial: Allow mctrl when flow control is disabled Date: Mon, 4 Mar 2019 09:22:23 +0100 Message-Id: <20190304081627.288050940@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190304081625.508788074@linuxfoundation.org> References: <20190304081625.508788074@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit e8a6ca808c5ed1e2b43ab25f1f2cbd43a7574f73 ] The geni set/get_mctrl() functions currently do nothing unless hardware flow control is enabled. Remove this arbitrary limitation. Suggested-by: Johan Hovold Fixes: 8a8a66a1a18a ("tty: serial: qcom_geni_serial: Add support for flow control") Signed-off-by: Matthias Kaehlcke Reviewed-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/qcom_geni_serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 1515074e18fb6..35d1f6fa0e3c3 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -221,7 +221,7 @@ static unsigned int qcom_geni_serial_get_mctrl(struct uart_port *uport) unsigned int mctrl = TIOCM_DSR | TIOCM_CAR; u32 geni_ios; - if (uart_console(uport) || !uart_cts_enabled(uport)) { + if (uart_console(uport)) { mctrl |= TIOCM_CTS; } else { geni_ios = readl_relaxed(uport->membase + SE_GENI_IOS); @@ -237,7 +237,7 @@ static void qcom_geni_serial_set_mctrl(struct uart_port *uport, { u32 uart_manual_rfr = 0; - if (uart_console(uport) || !uart_cts_enabled(uport)) + if (uart_console(uport)) return; if (!(mctrl & TIOCM_RTS)) -- 2.19.1