Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2278923imb; Mon, 4 Mar 2019 00:35:36 -0800 (PST) X-Google-Smtp-Source: AHgI3IZmH61C+O7Rk6gXFlbXbyyuF722o4FL0RyGXATOdil7yNZ6tMSHlp5TkDJto9s+waWnEF6j X-Received: by 2002:aa7:9141:: with SMTP id 1mr18849155pfi.38.1551688536198; Mon, 04 Mar 2019 00:35:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551688536; cv=none; d=google.com; s=arc-20160816; b=anb4zKoOslP9NVwrkVf9oaWw1nqnh0M0d0CzhKxnEhSy8PH+0b19rYI+Nr/hMHwvN7 mWGTDZL8KOMSHGi0HCY2mTqV0N7b81gaSoC6EQzUmzd1EE8reeOeqYePRd7cgGJfFNQN ItB8NePRk9gO7HtRXFsLx4Lhx+ptVt+55Qce/YUemBkngiheUJgowMRvYItdRkCBVSUQ czDkfFm0w6pIEoLot7QyvyPokvt2UEhrQgFmoAW+4CtHGPDyZ28jwdOoMM93UdZGwLLy ubXijjwhi0EFH4rxou4TG7heHhSkW5FYHHQYu56chK0OER76C6yUnkrofB9BQDyJYMVP NcCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dafUyJlGp7s8aHWlTCCs1GJxXgtGCRyrKNSgmrXGnUE=; b=g3YEuChdFE6/1Wr7qpiB9M+8qu4IuVxiDXYR+iVWbX1Ky7/H0lReKplyS6oYbRKy0f ZzcigD7dKXVV+P8dgOa9XTRJPeMHk5yPZaEJ97FnStG+H8+IKQ5IRVbgVt55xnekxbHQ SFw5q0wfM5IDR1f21aNjbKoYmBD5qdI0f2P+cjazkGq2qNil1oZDyMh2l2Nr6DT8PQXh bPREUZFp2Cgs9dnpauStR4+944eiNQIlexsB5cuLg0+tA8o8kPpbfSQP4LEEhG5iQv93 HoHN3bMF5GRK5BpIvJxp0/CjGKU5YWzFLNfF3PYz3swZ8GHHz/ER4tiSrgis0hCLSGxD mmlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fOmU0g4b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e71si4547832pgc.593.2019.03.04.00.35.21; Mon, 04 Mar 2019 00:35:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fOmU0g4b; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728065AbfCDIdt (ORCPT + 99 others); Mon, 4 Mar 2019 03:33:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:38856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727426AbfCDIdr (ORCPT ); Mon, 4 Mar 2019 03:33:47 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD85F20823; Mon, 4 Mar 2019 08:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551688427; bh=P+9Fco+ZYZrtBC+y/RN6QEdRgjtHFLcKr+wUmYHZJwc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fOmU0g4bSPYXHhIwrzQhqC4C7MIPiAzUDW5eRaq2zwMzJlXpn2cEfxnpwuPAiq6L8 oeffP24fDeOoVk4sh99+mSh0AP8zPQNj4indmB+iOcM7QU7b7ME//d/QspZopo1Abn m/rMrXxapu1PZLTsBnonNCKiM70B5Dmv4Wq15dPY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Matthias Kaehlcke , Sasha Levin Subject: [PATCH 4.20 40/88] tty: serial: qcom_geni_serial: Allow mctrl when flow control is disabled Date: Mon, 4 Mar 2019 09:22:23 +0100 Message-Id: <20190304081632.163670707@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190304081630.610632175@linuxfoundation.org> References: <20190304081630.610632175@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit e8a6ca808c5ed1e2b43ab25f1f2cbd43a7574f73 ] The geni set/get_mctrl() functions currently do nothing unless hardware flow control is enabled. Remove this arbitrary limitation. Suggested-by: Johan Hovold Fixes: 8a8a66a1a18a ("tty: serial: qcom_geni_serial: Add support for flow control") Signed-off-by: Matthias Kaehlcke Reviewed-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/qcom_geni_serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index d3b5261ee80af..76e0ad7251e1f 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -221,7 +221,7 @@ static unsigned int qcom_geni_serial_get_mctrl(struct uart_port *uport) unsigned int mctrl = TIOCM_DSR | TIOCM_CAR; u32 geni_ios; - if (uart_console(uport) || !uart_cts_enabled(uport)) { + if (uart_console(uport)) { mctrl |= TIOCM_CTS; } else { geni_ios = readl_relaxed(uport->membase + SE_GENI_IOS); @@ -237,7 +237,7 @@ static void qcom_geni_serial_set_mctrl(struct uart_port *uport, { u32 uart_manual_rfr = 0; - if (uart_console(uport) || !uart_cts_enabled(uport)) + if (uart_console(uport)) return; if (!(mctrl & TIOCM_RTS)) -- 2.19.1