Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2288945imb; Mon, 4 Mar 2019 00:57:37 -0800 (PST) X-Google-Smtp-Source: APXvYqzq2vx6xUhlp9foiHs5HsuIRGjfzLi52PC5AhVSzyDSj33sSa0PfOamUwE6iZ6LosULV2mm X-Received: by 2002:a17:902:202:: with SMTP id 2mr19768872plc.178.1551689857892; Mon, 04 Mar 2019 00:57:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551689857; cv=none; d=google.com; s=arc-20160816; b=0mGdVrhXebUaC9waM/dYVX/9Vh13panSgAxGF/huYIhLyHVzJfUaYUtoT48Btl2Qj4 dU9JTLUJ14uXjZr+SbcxSWi/dIIPnTSWK5DDFMSy4a9FMCwHgklw7TiJATOkRMhsfTKz Rem5apZ5pljgT+iDM2Gl7v/+kHWmCX10lvKEv2ftivCO4mPGNi4P+Mr69jKlrjtpppWJ NiE1d18xAslBsIMbFqM7CwdT/aT5qCLFHZTa9hzN1pbDCLXt1mapA9afugTTTdL5Zqvx 9zbae9DkRz6+ZvqPi40mCRYqS6nsFARgGeRXdjIzUpSr7c4+ClW1z5AJDIQ1GhmgiXzo UA4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cJf0Zhla6CgKds/oiFMeiqtfL5UQZB984dWPMrIMc4Q=; b=NxE+a/100XRIpmj74w0tNU4QPiwhf0YTwN1G7lMJ1+gKctvR9Ni/PACfiMjnf5HdPD /un4Fnu7x6FV32c19y/DoiDq58QXD/dMFujMBIV2x1+/liyGWcbwUgPudcvEnbP21VbC 1P5cj2uUUqpIr8H4hp2XQwqBMUDurxKsV4bEYzZY7pS3Vb67f05B+NFjduY3Mh/EPFui jQgUCZyljTM63TUW6Im8FTPoaC1jH9PVbJXXJ6rIT7xYiEirK6Ij7IV9H7838SZtVcVa 0UmjXT6X9OabaqGwVD4dn/PPF5n5ZjZtCERsZPhEdf/++0R/fgruitjgiu/2RuUdRBAc j3og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rfc2ZDJV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si4829571pgh.392.2019.03.04.00.57.22; Mon, 04 Mar 2019 00:57:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rfc2ZDJV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726173AbfCDI4w (ORCPT + 99 others); Mon, 4 Mar 2019 03:56:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:57786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbfCDI4w (ORCPT ); Mon, 4 Mar 2019 03:56:52 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EEEAE20823; Mon, 4 Mar 2019 08:56:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551689811; bh=8mBBQ/2gmb9gLqS8Y88FGtHKy9SyU79H2nRW5jzEHHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rfc2ZDJVtso50gzn8P0QsFJeX8OhKLbDuxArFB9pSuS7IawrNAYjNq9GjRdJeMrrJ 9D3dG7MvrgitqFuiGzxqoVDJ2ptPiS/cZ5jb9OkV0BZPcLFKhcFE7fKrSpKF72pMfq /sV2A9mwO2zClVlsRO+8rTvph6M+dEBZK7D/TAp8= Date: Mon, 4 Mar 2019 09:53:50 +0100 From: Greg Kroah-Hartman To: "He, Bo" Cc: "linux-kernel@vger.kernel.org" , Marek Szyprowski , "stable@vger.kernel.org" , "Wang, Yu Y" , Felipe Balbi , Sasha Levin Subject: Re: [PATCH 4.20 12/88] usb: dwc3: gadget: synchronize_irq dwc irq in suspend Message-ID: <20190304085350.GA18354@kroah.com> References: <20190304081630.610632175@linuxfoundation.org> <20190304081631.046461963@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 04, 2019 at 08:46:30AM +0000, He, Bo wrote: > Hi, Greg: > Marek Szyprowski report the patch has issue that calling synchronize_irq() under dwc->lock spinlock, he has upload the below patch for the issue: > > dwc3_gadget_suspend() is called under dwc->lock spinlock. In such context calling synchronize_irq() is not allowed. Move the problematic call out of the protected block to fix the following kernel BUG during system Is this patch in Linus's tree yet? If so, what is the git commit id? If not, is this also an issue in 5.0? thanks, greg k-h