Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Mar 2019 10:44:14 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     "He, Bo" <bo.he@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "Wang, Yu Y" <yu.y.wang@intel.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 4.20 12/88] usb: dwc3: gadget: synchronize_irq dwc irq in
 suspend
Message-ID: <20190304094414.GA12587@kroah.com>
References: <20190304081630.610632175@linuxfoundation.org>
 <20190304081631.046461963@linuxfoundation.org>
 <CD6925E8781EFD4D8E11882D20FC406D52A5C632@SHSMSX104.ccr.corp.intel.com>
 <CGME20190304085654epcas2p1284f13532438678e8ba53d232ca02a34@epcas2p1.samsung.com>
 <20190304085350.GA18354@kroah.com>
 <a3d017c7-d671-3ba9-15d6-0028595d5d59@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a3d017c7-d671-3ba9-15d6-0028595d5d59@samsung.com>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 04, 2019 at 10:03:27AM +0100, Marek Szyprowski wrote:
> Hi Greg,
> 
> On 2019-03-04 09:53, Greg Kroah-Hartman wrote:
> > On Mon, Mar 04, 2019 at 08:46:30AM +0000, He, Bo wrote:
> >> Hi, Greg:
> >> 	Marek Szyprowski report the patch has issue that calling synchronize_irq() under dwc->lock spinlock, he has upload the below patch for the issue:
> >>
> >> dwc3_gadget_suspend() is called under dwc->lock spinlock. In such context calling synchronize_irq() is not allowed. Move the problematic call out of the protected block to fix the following kernel BUG during system
> > <snip>
> >
> > Is this patch in Linus's tree yet?  If so, what is the git commit id?
> >
> > If not, is this also an issue in 5.0?
> 
> The fix has not been merged yet. The issue is also present in v5.0.

Ok, please make sure it is properly tagged for the stable releases and
we will be fine.

thanks,

greg k-h