Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2370309imb;
        Mon, 4 Mar 2019 03:28:21 -0800 (PST)
X-Google-Smtp-Source: APXvYqzjIuHeaSk80pDPFKmnlcoGp/i8Rj36W168kEX9+aQqqhIpEZ+ac3unEwACHRokOJpIpqK1
X-Received: by 2002:a17:902:bcc7:: with SMTP id o7mr20174443pls.89.1551698900947;
        Mon, 04 Mar 2019 03:28:20 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1551698900; cv=none;
        d=google.com; s=arc-20160816;
        b=0rNtEDaST5OVj6oDZGIeZu0uqZLYpxtvudV+CfbcvrTEHQLff49i5+CUO8gS9ZaueA
         R6469LWEw/saFNiv0iena8+PMOzv44fcdPrLsc90g2oqnGUYHsQgWFzRFN18w0ICwdib
         YjLwABZ8K4r5ZqbqbwPH0vT1laH/j82aiNRdG1qhcv/Lh+xxu32V77OuQArlwSAgZlwo
         HPPQ2b/pYQgv0hzJFmO2TfEmCagpBHumDx89Io2avOQhF1i/og7Ez5lkmqqDoaIwlFpL
         e1LGoUxJSYICsIMp6jGBywcpf1bpwiUwrtLpiSnApCpG0jNklyjb1RGae5Yii/h1c6NW
         Xwhw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=pa+/UtAHpTbSiS4249G2BVZAn/eGzsdv4R8WNC6QNiw=;
        b=O2DYD7rebFTV+rAP2+i9jF+Peh9p4ghp+3oNZef7wXQOKo21USiQTvP1v4q/F8Lh7o
         lqXm3QWPvhM+h7/33+14HnZK6V3D1Zao2RkIhIElP6vsKwAD9RVkIwVljtfR32/b1lfL
         ohyQuAWc0Ag7b93+2tudNk81jPvjJ8N2DqRBZg1o8quWOctWwSRxDtV9oci5Jxh5XHcu
         6YXC9fjWa1+jqFKNBA92+yuJ465F2rBW+yrnrtvwA0dvGE5CaNofOAm5q9pmV++DTo0n
         i4Zp9VnmMgWUeyzZJMXpdtC6iWUYqr9fird6O9OG02nuWKRMg9kl+9wpzl62ayzwu+Ty
         Tbbg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="TY1g7/9P";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id h62si4906423pge.410.2019.03.04.03.28.05;
        Mon, 04 Mar 2019 03:28:20 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="TY1g7/9P";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726429AbfCDL0n (ORCPT <rfc822;charleyewang@gmail.com>
        + 99 others); Mon, 4 Mar 2019 06:26:43 -0500
Received: from hqemgate15.nvidia.com ([216.228.121.64]:16246 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726090AbfCDL0n (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Mar 2019 06:26:43 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5c7d0b690000>; Mon, 04 Mar 2019 03:26:33 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 04 Mar 2019 03:26:41 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 04 Mar 2019 03:26:41 -0800
Received: from [10.24.242.33] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 4 Mar
 2019 11:26:35 +0000
Subject: Re: [PATCH] of: reserved_mem: disable kmemleak scan on removed memory
 blocks
To:     Nicolas Boichat <drinkcat@chromium.org>
CC:     Rob Herring <robh+dt@kernel.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Will Deacon <will.deacon@arm.com>, <matt@codeblueprint.co.uk>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Frank Rowand <frowand.list@gmail.com>,
        <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <talho@nvidia.com>,
        Stephen Warren <swarren@nvidia.com>, <vdumpa@nvidia.com>,
        <snikam@nvidia.com>, Mike Rapoport <rppt@linux.vnet.ibm.com>
References: <1541747389-28544-1-git-send-email-prpatel@nvidia.com>
 <CAL_JsqKOH0SQRXuRW5Y5dmWeUTSxhf2Nmn_0uNLeKXFPRc549Q@mail.gmail.com>
 <39d4161b-bcc0-0f1c-e7a3-5ad552fae724@nvidia.com>
 <CANMq1KDU=rTbwBdej+E0=RaWGQCOJrtKo_0W6kc=EdomNrKzog@mail.gmail.com>
 <CANMq1KDr7QdP3oJR2+w4mh_Gf3JUUNmV8h_KffBRjN7kA3P4EA@mail.gmail.com>
From:   Prateek Patel <prpatel@nvidia.com>
Message-ID: <b2127d64-0ea1-d7b1-6cf7-fb63e2a140db@nvidia.com>
Date:   Mon, 4 Mar 2019 16:56:24 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <CANMq1KDr7QdP3oJR2+w4mh_Gf3JUUNmV8h_KffBRjN7kA3P4EA@mail.gmail.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1551698793; bh=pa+/UtAHpTbSiS4249G2BVZAn/eGzsdv4R8WNC6QNiw=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=TY1g7/9Po8x0W3x1ai3JmA2Ns/p/yDOM4XZLbadYN2zJAPmp0TolfqgZutbOJDxN4
         SnIbUNQbcWWj338+w8tJSUC0xi55iiwzG+RqHFWIBqov3gZl4tX6NQcIAQrWpkHSQH
         jXjfnp61b05TQ4OY1IxN6rpPRyPYrZEZ+JuYycrBkEPeUBlWWSw5/PZ8wKhSL5RaOQ
         BMziRAW2MviyObSVxFbO8czDJbMrjzqtpfsCLipF21iIxRFKeSvo5TfnlCF0cePU2t
         E2rS2ORZZceDenos1BthrLE9Q4pQ1Ti5hU1XQutVvtI45zAcUL6XRTSEdjFOzEV76U
         TMHdbZbJfr5pQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/4/2019 4:04 PM, Nicolas Boichat wrote:
> On Wed, Feb 13, 2019 at 4:56 PM Nicolas Boichat <drinkcat@chromium.org> wrote:
>> On Tue, Jan 22, 2019 at 4:46 PM Prateek Patel <prpatel@nvidia.com> wrote:
>>>
>>> On 11/10/2018 2:58 AM, Rob Herring wrote:
>>>> On Fri, Nov 9, 2018 at 1:09 AM Prateek Patel <prpatel@nvidia.com> wrote:
>>>>> From: Sri Krishna chowdary <schowdary@nvidia.com>
>>>>>
>>>>> Memory reserved with "nomap" DT property in of_reserved_mem.c
>>>>> removes the memory block. The removed memory blocks don't have
>>>>> VA to PA mapping created in kernel page table. Kmemleak scan on
>>>>> removed memory blocks is causing page faults and leading to
>>>>> kernel panic. So, Disable kmemleak scan on the removed memory
>>>>> blocks.
>>>>>
>>>>> Following is the observed crash log:
>>>>> [  154.846370] Unable to handle kernel paging request at virtual address ffffffc070a00000
>>>>> <1>[  154.846576] Mem abort info:
>>>>> <1>[  154.846635]   Exception class = DABT (current EL), IL = 32 bits
>>>>> <1>[  154.846737]   SET = 0, FnV = 0
>>>>> <1>[  154.846796]   EA = 0, S1PTW = 0
>>>>> <1>[  154.846859] Data abort info:
>>>>> <1>[  154.846913]   ISV = 0, ISS = 0x00000006
>>>>> <1>[  154.846983]   CM = 0, WnR = 0
>>>>> <1>[  154.847053] swapper pgtable: 4k pages, 39-bit VAs, pgd = ffffff8009df7000
>>>>> <1>[  154.847228] [ffffffc070a00000] *pgd=000000087fff5803, *pud=000000087fff5803, *pmd=0000000000000000
>>>>> <0>[  154.847408] Internal error: Oops: 96000006 [#1] PREEMPT SMP
>>>>> <4>[  154.847511] Modules linked in: nvs_led_test nvs_bmi160 nvs_cm3218 nvs_bh1730fvc nvi_bmpX80 nvi_ak89xx nvi_mpu cdc_acm uas lr388k7_ts imx268 imx318 imx204 imx274 imx185 lc898212 ov23850 ov10823 ov9281 ov5693 tc358840 pca9570 nvs snd_soc_tegra_machine_driver_mobile lp855x_bl spidev input_cfboost pwm_tegra tegra_cryptodev tegra_se_nvhost tegra_se_elp tegra_se ghash_ce sha2_ce sha1_ce aes_ce_ccm cryptd nvgpu cpufreq_userspace snd_soc_tegra186_alt_dspk snd_soc_tegra186_alt_asrc snd_soc_tegra186_alt_arad snd_soc_tegra210_alt_ope snd_soc_tegra210_alt_mvc snd_soc_tegra210_alt_dmic snd_soc_tegra210_alt_amx snd_soc_tegra210_alt_adx snd_soc_tegra210_alt_afc snd_soc_tegra210_alt_mixer snd_soc_tegra210_alt_i2s snd_soc_tegra210_alt_sfc snd_soc_tegra210_alt_adsp snd_soc_tegra210_alt_admaif snd_soc_tegra210_alt_xbar
>>>>> <4>[  154.882606]  snd_soc_tegra_alt_utils snd_hda_tegra
>>>>> <4>[  154.888133] CPU: 2 PID: 8079 Comm: sh Not tainted 4.14.53-tegra-05132-g9c33465 #2
>>>>> <4>[  154.895983] Hardware name: e3360_1099 (DT)
>>>>> <4>[  154.900447] task: ffffffc7d62dda00 task.stack: ffffff800e2b0000
>>>>> <4>[  154.906502] PC is at scan_block+0x7c/0x148
>>>>> <4>[  154.911234] LR is at scan_block+0x78/0x148
>>>>> <4>[  154.915689] pc : [<ffffff8008271724>] lr : [<ffffff8008271720>] pstate: 804000c9
>>>>> <4>[  154.923290] sp : ffffff800e2b3b80
>>>>> <4>[  154.927228] x29: ffffff800e2b3b80 x28: ffffffc7d62dda00
>>>>> <4>[  154.932999] x27: ffffff8009aaa000 x26: ffffffc070c00000
>>>>> <4>[  154.938769] x25: 00000000000000c0 x24: ffffff8009d90608
>>>>> <4>[  154.944287] x23: ffffffc7dc6c6000 x22: ffffff8009d90000
>>>>> <4>[  154.950320] x21: ffffff8009aeb320 x20: ffffffc070a00ff9
>>>>> <4>[  154.955919] x19: ffffffc070a00000 x18: 00000000bec4c3f2
>>>>> <4>[  154.961438] x17: 0000002224777924 x16: ffffff80080bb0e0
>>>>> <4>[  154.967124] x15: 0000000000000000 x14: 0000000000000f75
>>>>> <4>[  154.973069] x13: 000fffffffffffff x12: ffffffbf1e9f4240
>>>>> <4>[  154.978670] x11: 0000000000000040 x10: 0000000000000ad0
>>>>> <4>[  154.984107] x9 : ffffff800e2b3ab0 x8 : ffffffc7d62de530
>>>>> <4>[  154.989958] x7 : 0000000780000000 x6 : 0000000000000018
>>>>> <4>[  154.995645] x5 : 0000000000000000 x4 : 0000000000000000
>>>>> <4>[  155.001245] x3 : ffffff8009aaa000 x2 : 00000047f6712000
>>>>> <4>[  155.006846] x1 : ffffffc7d1ae6900 x0 : 0000000000000000
> [snip]
>
> For reference, there is another patch series that fixes the problem,
> by Mike Rapoport (https://lore.kernel.org/patchwork/patch/1041790/),
> already in linux-next (through mmotm):
> 42c9c0ac24393c of: fix kmemleak crash caused by imbalance in early
> memory reservation
> 48ec6d51f7d3f2 of: fix parameters order for call to memblock_find_in_range()
>
> If anyone is interested, I backported these patch to our 4.19 tree
> here, and they fix the issue:
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1496707
> https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1496708
>
> Thanks,

Thanks Nicolas for the reference,

My acked-by is already present in the patch 
(https://lore.kernel.org/patchwork/patch/1041790/)