Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <362a9b5f-8908-17f5-3594-6c3c68789dea@molgen.mpg.de>
 <CAEJqkggKGTn0ojWzuYGfoYehDnOf=je5L-7-M1kWogutPGMg3g@mail.gmail.com> <874l8ic0l4.fsf@codeaurora.org>
In-Reply-To: <874l8ic0l4.fsf@codeaurora.org>
From:   Gabriel C <nix.or.die@gmail.com>
Date:   Mon, 4 Mar 2019 14:00:40 +0100
Message-ID: <CAEJqkgjYRu1Az6ec1ksQfLZ71fa062Us7XkOzw8BZ2bEoUe8BQ@mail.gmail.com>
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Paul Menzel <pmenzel@molgen.mpg.de>, ath10k@lists.infradead.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am Mo., 4. M=C3=A4rz 2019 um 12:59 Uhr schrieb Kalle Valo <kvalo@codeaurora=
.org>:
>
> Gabriel C <nix.or.die@gmail.com> writes:
>
> > Am Mo., 4. M=C3=A4rz 2019 um 12:28 Uhr schrieb Paul Menzel <pmenzel@mol=
gen.mpg.de>:
> >
> >> Resuming from ACPI S3 on the Dell XPS 13 9370 with Debian Sid/unstable=
,
> >> Linux 4.19.20 showed the warning below. It=E2=80=99s not reproducible.
>
> [...]
>
> >> [ 3018.992916] Call Trace:
> >> [ 3018.992921]  ? ath10k_conf_tx+0x7a/0x4b0 [ath10k_core]
> >> [ 3018.992937]  ieee80211_bss_info_change_notify+0xab/0x1a0 [mac80211]
> >> [ 3018.992946]  ieee80211_reconfig+0x661/0x12a0 [mac80211]
> >> [ 3018.992962]  wiphy_resume+0x7f/0x120 [cfg80211]
> >> [ 3018.992969]  ? wiphy_suspend+0x270/0x270 [cfg80211]
> >> [ 3018.992971]  dpm_run_callback+0x59/0x150
> >> [ 3018.992972]  device_resume+0x97/0x190
> >> [ 3018.992973]  async_resume+0x19/0x30
> >> [ 3018.992974]  async_run_entry_fn+0x39/0x160
> >> [ 3018.992976]  process_one_work+0x1a7/0x3a0
> >> [ 3018.992978]  worker_thread+0x30/0x390
> >> [ 3018.992979]  ? pwq_unbound_release_workfn+0xd0/0xd0
> >> [ 3018.992980]  kthread+0x112/0x130
> >> [ 3018.992981]  ? kthread_bind+0x30/0x30
> >> [ 3018.992983]  ret_from_fork+0x35/0x40
> >> [ 3018.992984] ---[ end trace 3af618ca97bd4a0a ]---
> >> ```
> >>
> >> Please find all Linux messages attached.
> >
> > I reported that twice and no one seems to care about.
> >
> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.html
> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.html
>
> Does this patch help:
>
> ath10k: Drop WARN_ON()s that always trigger during system resume
>
> https://patchwork.kernel.org/patch/10837139/
>

Without to test this patch I can confirm it will help , I dropped the
WARN_ON()'s in 4.19 already.
If I remember right 4.19 has one WARN_ON() triggers while 4.20 got two.

https://gitweb.frugalware.org/frugalware-current/blob/master/source/base/ke=
rnel/ath10k-drop-WARN_ON-added-in-cd93b83ad927b2c7979e0add0343ace59328b461.=
patch

BR,

Gabriel C