Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] vfs: Move kernel_read_file() to fs/read_write.c
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     David Howells <dhowells@redhat.com>
Cc:     viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 04 Mar 2019 11:49:16 -0500
In-Reply-To: <12096.1551716540@warthog.procyon.org.uk>
References: <1551715930.10911.468.camel@linux.ibm.com>
         <155171231301.4764.5429281379303710262.stgit@warthog.procyon.org.uk>
         <12096.1551716540@warthog.procyon.org.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-Id: <1551718156.10911.473.camel@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-03-04 at 16:22 +0000, David Howells wrote:
> Mimi Zohar <zohar@linux.ibm.com> wrote:
> 
> > > Move kernel_read_file() to fs/read_write.c and out of fs/exec.c as it's not
> > > actually used by anything in the execve subsystem.
> > 
> > All files being opened by the kernel should be calling one of these
> > helper routines.  Has that changed?
> 
> prepare_binprm() uses kernel_read() and has done since at least 2014.  The
> binfmt drivers also use kernel_read().
> 
> Since kernel_read_file() is used by a bunch of things that aren't exec, even
> if we switch exec to it, it should probably still go in fs/read_write.c since
> it seems generic.

Oh, commit bdd1d2d3d251 ("fs: fix kernel_read prototype") moved
kernel_read() to fs/read_write.c without moving the helpers.
 Definitely makes sense to move the helpers.  Please include a
reference to the commit in this patch. 

Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>