Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Mar 2019 19:13:49 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com>
Cc:     Boris Brezillon <bbrezillon@kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chuanhong Guo <gch981213@gmail.com>,
        "Richard Weinberger" <richard@nod.at>,
        Schrempf Frieder <frieder.schrempf@kontron.De>,
        Marek Vasut <marek.vasut@gmail.com>,
        Frieder Schrempf <frieder.schrempf@exceet.de>,
        Brian Norris <computersforpeace@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        "Bean Huo (beanhuo)" <beanhuo@micron.com>
Subject: Re: [EXT] Re: [PATCH 2/2] mtd: spinand: micron: Support for all
 Micron SPI NAND flashes
Message-ID: <20190304191349.71f8b147@xps13>
In-Reply-To: <MN2PR08MB5951EE4ACB78BAD12EDA5F76B8710@MN2PR08MB5951.namprd08.prod.outlook.com>
References: <MN2PR08MB5951FD3B8244ABBA72FF7430B86D0@MN2PR08MB5951.namprd08.prod.outlook.com>
        <20190204190151.2c7987b7@bbrezillon>
        <MN2PR08MB5951EE4ACB78BAD12EDA5F76B8710@MN2PR08MB5951.namprd08.prod.outlook.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello,

"Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com> wrote on
Mon, 4 Mar 2019 13:29:21 +0000:

> Hi Boris,
> 
> > -----Original Message-----
> > From: Boris Brezillon <bbrezillon@kernel.org>
> > Sent: Monday, February 4, 2019 7:02 PM
> > To: Shivamurthy Shastri (sshivamurthy) <sshivamurthy@micron.com>
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com>; linux-
> > mtd@lists.infradead.org; linux-kernel@vger.kernel.org; Chuanhong Guo
> > <gch981213@gmail.com>; Richard Weinberger <richard@nod.at>; Schrempf
> > Frieder <frieder.schrempf@kontron.De>; Marek Vasut
> > <marek.vasut@gmail.com>; Frieder Schrempf
> > <frieder.schrempf@exceet.de>; Brian Norris
> > <computersforpeace@gmail.com>; David Woodhouse
> > <dwmw2@infradead.org>; Bean Huo (beanhuo) <beanhuo@micron.com>
> > Subject: [EXT] Re: [PATCH 2/2] mtd: spinand: micron: Support for all Micron
> > SPI NAND flashes
> > 
> > Hi Shivamurthy,
> > 
> > On Mon, 4 Feb 2019 11:17:51 +0000
> > "Shivamurthy Shastri (sshivamurthy)" <sshivamurthy@micron.com> wrote:
> >   
> > > Driver is redesigned using parameter page to support all the Micron
> > > SPI NAND flashes.  
> > 
> > Do all Micron SPI NANDs really expose a valid ONFI param page? If
> > that's not the case, then relying on ONFi parsing only sounds like a
> > bad idea.  
> 
> Micron SPI NAND datasheet does not confirm to be as ONFI standard.
> However, they all expose parameter page, which I used for development.
> 
> >   
> > >
> > > Parameter page of Micron flashes is similar to ONFI parameter table and
> > > functionality is same, so copied some of the common functions like crc16
> > > and bit_wise_majority from nand_onfi.c.  
> > 
> > Most of the code is generic and does not depend on the spinand layer,
> > plus, we already have ONFI param page parsing code in
> > drivers/mtd/nand/raw/ which you're intentionally duplicating in a
> > version that will not be re-usable by the raw NAND layer even after
> > converting it to use the generic NAND layer.
> > 
> > Please move ONFi parsing code to drivers/mtd/nand/onfi.c and make it
> > generic.  
> 
> As I said before, it is not compliant to ONFI standard, I think it is better not 
> to make it generic.

For what I see it is too similar to copy all that code. I agree with
Boris. If there are some specificities that are not in the ONFI
standard you can do some late changes in the parameter page from
Micron's driver I guess?


Thanks,
Miquèl