Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Helen Koike <helen.koike@collabora.com>
To:     eric@anholt.net
Cc:     linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        stefan.wahren@i2se.com, linus.walleij@linaro.org, lkundrak@v3.sk,
        bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org,
        kernel@collabora.com
Subject: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
Date:   Mon,  4 Mar 2019 15:54:54 -0300
Message-Id: <20190304185454.18043-1-helen.koike@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello,

I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
driver, the HDMI wans't being detected.

So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
works correctly. I can see that modeprint from libdrm detects correctly
when the display is plugged and when it is unpluggled.

So I was wondering if this is just in my board or if there is an error
in the dts (which I think it's unlikely).

In any case I am dropping this email here in case anyone else see this
problem, if you do, try appliying the patch below.

Regards,
Helen

---
 arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
index 5641d162dfdb..28e7513ce617 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
@@ -93,7 +93,7 @@
 };
 
 &hdmi {
-	hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
+	hpd-gpios = <&gpio 46 GPIO_ACTIVE_HIGH>;
 };
 
 &pwm {
-- 
2.20.1