Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2705231imb; Mon, 4 Mar 2019 11:55:45 -0800 (PST) X-Google-Smtp-Source: APXvYqx+vM/mBPnu20QSDT99yc8c794TPjnC0T3XEkYJswo0hLpSXjyGtB0g+X0JqjYUzMJNODxn X-Received: by 2002:a17:902:4303:: with SMTP id i3mr3971290pld.152.1551729345401; Mon, 04 Mar 2019 11:55:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551729345; cv=none; d=google.com; s=arc-20160816; b=d/RJQmXqnLcM4G1lr/sfFITtMLNtJ87ib2xf6fQxyRYxzEuaTb/Z53U/Md7QEI3Y/e dKbrXtBYYQB203q5kU19L9XdoFSQz5glrLUUcd5OecMDVV8jfsSnuV0KwZfx3ssbheeQ i0kzAByfcp6zPVGeiPmBPgobkNWbmhaUUDeaAMAoZ//y3OucHwATyGarBNqPenKiwbHj J2INVIbfC27G82b6cHqVfu+UQthsvLP3f/8py8DJmt79liVBNcOQ5lsMDPh3iwu4QH7M RzCfep9IUKkcTmWY1Cu1UtsHarWa+ChyWCEbJUk9Cf+wdA6rS47YwrMbqVMZJj6uTpvi GMHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pxef9rdvAgoIkuYMMkRzJku1e77+iPvyDWdKoXG/LJc=; b=zMZBfYXH8/xDOoosqAK3LSN/t133YdV9thHLqRmYYyk2Et2AHLiIQmfSotYpX0KI1C 1IUyq/G8eB6hFRL7oS4O5qt6Sm8vMaMz+HFPm6YVq+Eydzi1+468Dl4iqIWxt+Eh4fRL QHVo/s9PSL/g15lttUWfkV3MtbPiyoPBkOhLrGqADk0bepgeqNsGvN1/de1nI9Z/6FgW tdE+Bqy3dHMO2EQEgrK9ZELv9jrr3uvj1ShWAUFlLSNASCaOwcf/j1y82frWSuryfnzX dwdhY/tuBDHJ6/zGCoW3o1pSxSCPZcVM3qSqzvcL+tM4YZqDYwgJujfqj7rQD4JmDAAu Riig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ikd1IfSn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g127si5745647pgc.313.2019.03.04.11.55.30; Mon, 04 Mar 2019 11:55:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ikd1IfSn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726355AbfCDTxz (ORCPT + 99 others); Mon, 4 Mar 2019 14:53:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:46292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbfCDTxz (ORCPT ); Mon, 4 Mar 2019 14:53:55 -0500 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D7FF520657; Mon, 4 Mar 2019 19:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551729234; bh=giA6uiGuJHeAeWZdu7sapZruLOXqUI5GTktC7GOoboA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ikd1IfSntVPb0jCcMvR23FsW66mmRPg+Ya5PloGrKhnh5ubKMv9akgFuOcgUavQ5A Gj1XK1+esNYB1ShEAhwM6zDPbgXRkAJ7E30YYkZPtpmh8Cy7xneTjGUuwbKJs0g1w+ NkIHa2hCd4BOJKrnwF8Xivzt/ziElTavVoXspJxY= Date: Mon, 4 Mar 2019 21:53:51 +0200 From: Leon Romanovsky To: john.hubbard@gmail.com Cc: linux-mm@kvack.org, Andrew Morton , LKML , John Hubbard , Ira Weiny , Jason Gunthorpe , Doug Ledford , linux-rdma@vger.kernel.org Subject: Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path Message-ID: <20190304195351.GK15253@mtr-leonro.mtl.com> References: <20190304194645.10422-1-jhubbard@nvidia.com> <20190304194645.10422-2-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SzQ167Kp6Zo0TWVn" Content-Disposition: inline In-Reply-To: <20190304194645.10422-2-jhubbard@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --SzQ167Kp6Zo0TWVn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubbard@gmail.com wrote: > From: John Hubbard > > 1. Bug fix: fix an off by one error in the code that > cleans up if it fails to dma-map a page, after having > done a get_user_pages_remote() on a range of pages. > > 2. Refinement: for that same cleanup code, release_pages() > is better than put_page() in a loop. > > Cc: Leon Romanovsky > Cc: Ira Weiny > Cc: Jason Gunthorpe > Cc: Andrew Morton > Cc: Doug Ledford > Cc: linux-rdma@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: John Hubbard > --- > drivers/infiniband/core/umem_odp.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > Thanks, Acked-by: Leon Romanovsky --SzQ167Kp6Zo0TWVn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcfYJPAAoJEORje4g2clinTO4P/0fRa+62AVNr9diB7JwN2q00 R/xwy4BeamgibjxK4ajFxNiuOe8kWL4M0xidWvIUIjhsljdVwNtyKUfH6SYi3YdM chSj9iQeluos07CWbM9VPyGGBHZfQ13aTCy9P4tx/3JD+D03lZDBoP3tm93Mms4L mxQwjxdBnBaquIpD98cIPZm31XXFUcRR/K7kMnPOBcXp+f2yx6DfJprm3tffb2Ke 9NgfVcIV03ZlfeC/NI2bj/MC17PZgZZBK2XqVTi7Wu0iYcy9J8nRlD2kVjNq/0rG kxPMZ/O2K65gwnNSWtWPxsL074ekD4P5Mcn9D6Qa0MeFGotoGdDrEH9gJ4hmGFxG 1vgWYZRJ26JCoGASInbPKmPQBjC1bfHyUG83E8qfHHyTDzHj8ytcXXFtW2JMCSOi nbqqX7ww8sXyAbCW2546yxCQ3AIL93g42gkwgGoxtQioovSkQ0eJoYSOT4cDxYEY nsECMJGMhey3kqDDQGGvzZ31RZ7byaMQY/p6mc5hewRf8HOKHJEslsA1uTh5DkHq j4duANKV3tZyw3sWQ+bf4s2NE0/EzH4wqIQWN2x7J6u+GDGM+JM9uLalXA+2tN+e ks9z1cS4AXflaeIpV4q7p/bdqJf3JfrSsNY9WLFiryjF5q9c/4ejwYIRcsN1wq7D v4WszJR2m5vaYxbOgMxo =wIFY -----END PGP SIGNATURE----- --SzQ167Kp6Zo0TWVn--