Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp2728252imb; Mon, 4 Mar 2019 12:32:58 -0800 (PST) X-Google-Smtp-Source: APXvYqz8Mf2PKYe98CUOhnj0lKsdSYp57mlmLvjJkQwzQLQGmz2u9JlKcngOKjphlUBvSu330/Fn X-Received: by 2002:a62:2b88:: with SMTP id r130mr21654600pfr.93.1551731577949; Mon, 04 Mar 2019 12:32:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551731577; cv=none; d=google.com; s=arc-20160816; b=W08/qvfceYYtZ94h2Sk1bqMQIiyEEX+z9zSPYdpmnVh+VjulbE8Ss3xRrx7daUT4Rv r3WeUbq0Q26l5JL2DtU2EBqFFls0bRdIF+WVcs9JKKUaSUre7Nam0qLb1z/aqIB7+cgC 43/XdIWAcyEMA0bnhQWoKFf1SXPYSnucV/fJjW6VvyPu+qE8AlGKZ5hdpMHJhzCyzFRe l1iifCFBcdnShshX3uVWtyigS3X9Ket9T5WABeccv7Gj4v4yAqUoEhMg9aaSRlLlY3/l VyxShNvMjqOkI6obMBlQFDOqpEbJ3dYguqTdq5EM2lxq50NMJp8ejL66V4XVfmrJQ8ry aaqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=z9mIcxxt8Vhpd9V+/EyizlMRIl0unlkK0sf4EYC970w=; b=wrBiEt0gh5ix+3ZUiktdxyM0VTZwWLYIhNFmmUsGF11by+KpwzQpJWoLl8RrYuhQP7 OBDl4HS32NkuhPRd1Qn3hKuQyP2nFRdWVcIUiQdg6HpZqdcKg1VXih64WnwE9O0hpMMY 2Q6WF8obO91vhBznpofbBThrhGVeNkCnF9ewuJUKeQ0t1o8kP2Dj0ios43x2CMMT/8Lz 76tJMqe+0rwa1yElJaE5ijhLNSlr2bMwGNeI+VCAyb5pbJmqo1pvttQyfFQ4QofuO9Gi O3nvfRMX6jbLs9QQlc538uzt07gzE7wcWyIgmQr+C85918ggAGV7+mtUCbJ2libCHtzf Gzdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=JFeTGKR4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si5996913pgn.404.2019.03.04.12.32.43; Mon, 04 Mar 2019 12:32:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=JFeTGKR4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726481AbfCDUbf (ORCPT + 99 others); Mon, 4 Mar 2019 15:31:35 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:34308 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfCDUbf (ORCPT ); Mon, 4 Mar 2019 15:31:35 -0500 Received: by mail-qk1-f194.google.com with SMTP id a15so3559394qkc.1 for ; Mon, 04 Mar 2019 12:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z9mIcxxt8Vhpd9V+/EyizlMRIl0unlkK0sf4EYC970w=; b=JFeTGKR46hqecjdgXUCXA+PrbOcfhOUKyqsz887pdoaKWDSgn6hDTL0Vw2FtXeY27z uqHxm+aSfSxHxZ04/5/ZtHeiRLJEW7inwMIPplCUR4hpul8lUHW40ct3ly1elJgUOtl3 2f7QDs6t+X10nndWu2iI0sbpfI2fUOIuDRKNJlnEQK9p17hrAo/g/LtwaD8rWGOATZG9 /Z+HAQhJD3m9L4bWuMRZNEIloPHbC/1kenvBf/HdjZ5ZRgkljDYALHNnXkZn20kyTsfd u/JCaroIdy8grFikzQJOZwoS9sX/C/R/aTXdqEFhaZl9tooNa1cnx7fhZisHUuw/d1Zy cd3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z9mIcxxt8Vhpd9V+/EyizlMRIl0unlkK0sf4EYC970w=; b=WiU5yrCTrBbf3SknF0nbcvNw8S9etdjku/LfffMJ1LaDuGtiVVFhwgosqI6R6Slg6z xFH1nITSieyw07auDUN0h0ldfSbogGEu9Fd+gVE7SEEZtHnmok9Dxeh9NQDSlmM398j8 KaVJums7/6sRqLjj5vvAvxbgnN/vnawWUnrO1ajgZu+iYXA0SOxdfc9fBs/B0MQn1HZ5 mKeoKFyDNPBVRlnhWru+BVNpW/RvJHm9FZ+A3ML+Z9phgb11vCLCvSZMXxODrP7qdZ90 0NcYFSecJHtisw2txk+zBu73cCji86ystpTl9IhKQ9rlR7oSfIjTKKM1nsIwmZgDi30s wkfA== X-Gm-Message-State: APjAAAXtynDRE0WPZkWrgtfpv/1e3CACJ4sS9AV//LHeZ1q3wo6Ez1r9 t+CkxTqsJouQeyX9cNIeqjTjLA== X-Received: by 2002:ae9:ec19:: with SMTP id h25mr15120648qkg.122.1551731493848; Mon, 04 Mar 2019 12:31:33 -0800 (PST) Received: from ziepe.ca ([24.137.65.181]) by smtp.gmail.com with ESMTPSA id f58sm4696098qtc.14.2019.03.04.12.31.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2019 12:31:33 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1h0uFI-0000Hb-73; Mon, 04 Mar 2019 16:31:32 -0400 Date: Mon, 4 Mar 2019 16:31:32 -0400 From: Jason Gunthorpe To: john.hubbard@gmail.com Cc: linux-mm@kvack.org, Andrew Morton , LKML , John Hubbard , Leon Romanovsky , Ira Weiny , Doug Ledford , linux-rdma@vger.kernel.org Subject: Re: [PATCH v3] RDMA/umem: minor bug fix in error handling path Message-ID: <20190304203132.GA1055@ziepe.ca> References: <20190304194645.10422-1-jhubbard@nvidia.com> <20190304194645.10422-2-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190304194645.10422-2-jhubbard@nvidia.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 04, 2019 at 11:46:45AM -0800, john.hubbard@gmail.com wrote: > From: John Hubbard > > 1. Bug fix: fix an off by one error in the code that > cleans up if it fails to dma-map a page, after having > done a get_user_pages_remote() on a range of pages. > > 2. Refinement: for that same cleanup code, release_pages() > is better than put_page() in a loop. > > Cc: Leon Romanovsky > Cc: Ira Weiny > Cc: Jason Gunthorpe > Cc: Andrew Morton > Cc: Doug Ledford > Cc: linux-rdma@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: John Hubbard > Signed-off-by: Ira Weiny > Reviewed-by: Ira Weiny > Acked-by: Leon Romanovsky > --- > drivers/infiniband/core/umem_odp.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Applied to for-next, thanks Jason