Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Christian Brauner <christian@brauner.io>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Luis Chamberlain <mcgrof@kernel.org>,
        "Kees Cook" <keescook@chromium.org>,
        Alexei Starovoitov <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        Martin Lau <kafai@fb.com>, Yonghong Song <yhs@fb.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH] bpf: fix sysctl.c warning
Thread-Topic: [PATCH] bpf: fix sysctl.c warning
Thread-Index: AQHU0sm+UeSSE6xtCkCep443A8dW2KX79B2AgAAAfIA=
Date:   Mon, 4 Mar 2019 20:58:59 +0000
Message-ID: <C94EB246-92FE-4A8D-AD60-C3D6F8292C0E@fb.com>
References: <20190304203443.1992942-1-arnd@arndb.de>
 <20190304205714.rhpgpp26rbaghs2i@brauner.io>
In-Reply-To: <20190304205714.rhpgpp26rbaghs2i@brauner.io>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9C1F0496849C3E4E80BAAE6BB9CE8DD3@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a91502ec-3858-47a0-d3c9-08d6a0e439bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2019 20:58:59.9130
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1822
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-04_11:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 4, 2019, at 12:57 PM, Christian Brauner <christian@brauner.io> wro=
te:
>=20
> On Mon, Mar 04, 2019 at 09:34:12PM +0100, Arnd Bergmann wrote:
>> When CONFIG_BPF_SYSCALL or CONFIG_SYSCTL is disabled, we get
>> a warning about an unused function:
>>=20
>> kernel/sysctl.c:3331:12: error: 'proc_dointvec_minmax_bpf_stats' defined=
 but not used [-Werror=3Dunused-function]
>> static int proc_dointvec_minmax_bpf_stats(struct ctl_table *table, int w=
rite,
>>=20
>> The CONFIG_BPF_SYSCALL check was already handled, but the SYSCTL check
>> is needed on top.
>>=20
>> Fixes: 492ecee892c2 ("bpf: enable program stats")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>=20
> Reviewed-by: Christian Brauner <christian@brauner.io>

Acked-by: Song Liu <songliubraving@fb.com>

>=20
>> ---
>> kernel/sysctl.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
>> index 46a0d0a14a66..b3df3ab7ac28 100644
>> --- a/kernel/sysctl.c
>> +++ b/kernel/sysctl.c
>> @@ -3330,7 +3330,7 @@ int proc_doulongvec_ms_jiffies_minmax(struct ctl_t=
able *table, int write,
>>=20
>> #endif /* CONFIG_PROC_SYSCTL */
>>=20
>> -#ifdef CONFIG_BPF_SYSCALL
>> +#if defined(CONFIG_BPF_SYSCALL) && defined(CONFIG_SYSCTL)
>> static int proc_dointvec_minmax_bpf_stats(struct ctl_table *table, int w=
rite,
>> 					  void __user *buffer, size_t *lenp,
>> 					  loff_t *ppos)
>> --=20
>> 2.20.0
>>=20