Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Mar 2019 16:56:53 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tom Zanussi <zanussi@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
        Tom Zanussi <tom.zanussi@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 2/2] tracing: Use strncpy instead of memcpy for string
 keys in hist triggers
Message-ID: <20190304165653.17699f9f@gandalf.local.home>
In-Reply-To: <20190304165000.0ce0fbdd@gandalf.local.home>
References: <cover.1549309756.git.tom.zanussi@linux.intel.com>
        <50c35ae1267d64eee975b8125e151e600071d4dc.1549309756.git.tom.zanussi@linux.intel.com>
        <20190304165000.0ce0fbdd@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 4 Mar 2019 16:50:00 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> > +++ b/kernel/trace/trace_events_hist.c
> > @@ -4695,9 +4695,10 @@ static inline void add_to_key(char *compound_key, void *key,
> >  		/* ensure NULL-termination */
> >  		if (size > key_field->size - 1)
> >  			size = key_field->size - 1;
> > -	}
> >  
> > -	memcpy(compound_key + key_field->offset, key, size);
> > +		strncpy(compound_key + key_field->offset, (char *)key, size);
> > +	} else
> > +		memcpy(compound_key + key_field->offset, key, size);
> >  }
> >    
> 
> Shouldn't we use strncpy() in save_comm() too. Feels safer.

Note, if that is changed, it can be another patch. This one is fine as
is. I just was looking at other use cases of memcpy() in that file.

-- Steve